Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Running ../vendor/bin/phpcs produces a few coding standards regression that can be auto-fixed with phpcbf.
Comment | File | Size | Author |
---|---|---|---|
#2 | phpcs-regressions-2851510-2.patch | 5.61 KB | klausi |
Comments
Comment #2
klausipatch.
Comment #3
dawehnerI'm a bit curious how this happened ...
Comment #6
xjmIs this with 8.2.8? Must be since I don't see the @return things etc.
I'll ask around about committers' pre-commit hooks. I botched a commit in the opposite way because I was already apparently on 8.2.10 and am not yet relying on the dev dependency.
Committed to both branches to avoid merge conflicts/backport issues. Thanks!
Comment #7
xjmWe could also check git blame to see which committer might need to tweak their toolchain.
Comment #8
xjmComment #9
xjmSorry, editing to trim that log to the relevant commits.
Comment #10
xjmThat was messier than it should have been. Anyway, looks like catch's pre-commit hook sniffs broke in December or so. I pinged him about it.
Thanks!
Comment #11
cilefen CreditAttribution: cilefen commentedhttps://github.com/alexpott/d8githooks/pull/11
Comment #12
xjmFor clarity, #11 is the potential fix for my issue, not @catch's AFAIK.