Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
When the moono-lisa skin is added to core the config UI css will not match the editor css.
Proposed resolution
Update the config ui css to match moono-lisa
Remaining tasks
Review patch.
User interface changes
CKEditor config UI will look like this:
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff.patch | 2.24 KB | droplet |
#10 | 2850508-update-ckui-moonolisa-10.patch | 17.94 KB | droplet |
#7 | mouse.gif | 58.71 KB | GrandmaGlassesRopeMan |
#7 | keyboard.gif | 71.57 KB | GrandmaGlassesRopeMan |
#3 | Screen Shot 2017-02-07 at 11.49.00 AM.png | 126.25 KB | tkoleary |
Comments
Comment #2
tkoleary CreditAttribution: tkoleary at Acquia commentedI am aware that this patch breaks the javascript somewhat. Notably:
@wimleers or someone else with more javascript expertise than me will need to look at that.
Comment #3
tkoleary CreditAttribution: tkoleary at Acquia commentedComment #4
tkoleary CreditAttribution: tkoleary at Acquia commentedComment #5
webchickComment #6
Wim LeersIndeed, dragging-and-dropping of additional buttons onto the "Active Toolbar" is completely broken now.
I suspected HTML changes, but no. The HTML is completely identical.
So, the only possible culprit is the CSS. The CSS is somehow breaking the "drop" targets. Quite possibly it is causing them to not show up at all.
Hence I took a look at the patch. This is pretty much rewriting all of the CSS. Rather than having focused changes, it seems to be modifying and moving lots of things for no reason at all. Kevin, can you please reroll the patch and reduce the number of changes?
Comment #7
GrandmaGlassesRopeMan@Wim Leers +1
There are some strange issues around dragging buttons into their respective targets. Perhaps the sizes for them indicated in the CSS have been removed or are incorrect?
Keyboard functionality still works, however any visual indication is now missing.
Broken mouse drag/drop functionality,
Comment #8
tkoleary CreditAttribution: tkoleary at Acquia commented@drpal
I suspect that behaviors in the js were tied to elements with attributes like borders or backgrounds that no longer display in this style.
Comment #9
Wim LeersThat seems unlikely. It seems more likely that the drop targets are no longer given any dimensions, and hence fail to show up.
Also: the absence of contrast makes this much harder to use. I think I prefer keeping the current configuration UI, because it makes is MUCH clearer where buttons are, where button groups are, and hence where you can drag buttons to.
Finally: the "Add group" button doesn't look like a button at all anymore, at least not until you hover above it.
Comment #10
droplet CreditAttribution: droplet commented- Fixed #7
Never known this is customized styling. I just patched it but didn't check if the new CSS style correct or not.
** not really a JS issue. Removing JS tag but tagging "Needs JS testing" (I think committers will ask for it)
Comment #11
yoroy CreditAttribution: yoroy at Roy Scholten commentedComment #12
benjifisherComment #23
quietone CreditAttribution: quietone at PreviousNext commentedCKEditor has been removed from core, CKEditor 4 is removed from Drupal Core in 10.0.0