Problem/Motivation

Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method

Proposed resolution

Write EntityResourceTestBase subclass for the ImageStyle entity.

Remaining tasks

References

1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.

CommentFileSizeAuthor
#5 interdiff-2843786-3-5.txt534 bytesshadcn
#5 entityresource_provide-2843786-5.patch9.04 KBshadcn
#3 entityresource_provide-2843786-3.patch9.04 KBshadcn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
Version: 8.3.x-dev » 8.4.x-dev
Assigned: Unassigned » shadcn
Status: Active » Needs review
FileSize
entityresource_provide-2843786-3.patch9.04 KB

Ready for review.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

Just one supernit:

+++ b/core/modules/rest/tests/src/Functional/EntityResource/ImageStyle/ImageStyleResourceTestBase.php
@@ -0,0 +1,113 @@
+   * The effect uuid.

s/uuid/UUID/

(This doesn't need to block commit though.)

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
FileSize
entityresource_provide-2843786-5.patch9.04 KB
interdiff-2843786-3-5.txt534 bytes

Done. Thanks @Wim Leers.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 5955462 to 8.4.x and c2b6294 to 8.3.x. Thanks!

  • alexpott committed 5955462 on 8.4.x 
    Issue #2843786 by arshadcn: EntityResource: Provide comprehensive test...

  • alexpott committed c2b6294 on 8.3.x 
    Issue #2843786 by arshadcn: EntityResource: Provide comprehensive test...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.