Problem/Motivation

Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method

Proposed resolution

Write EntityResourceTestBase subclass for the CommentType entity.

Remaining tasks

References

1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.

CommentFileSizeAuthor
#6 interdiff-2843775-3-6.txt687 bytesshadcn
#6 entityresource_provide-2843775-6.patch7.9 KBshadcn
#3 entityresource_provide-2843775-3.patch7.9 KBshadcn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
Version: 8.3.x-dev » 8.4.x-dev
Assigned: Unassigned » shadcn
FileSize
entityresource_provide-2843775-3.patch7.9 KB

OK. Let's test this.

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
Status: Active » Needs review
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community 
  1. +++ b/core/modules/rest/tests/src/Functional/EntityResource/CommentType/CommentTypeResourceTestBase.php
@@ -0,0 +1,77 @@
+    // Create a "Camelids" comment type entity.

    Supernit: s/comment type entity/comment type/ 

  2. +++ b/core/modules/rest/tests/src/Functional/EntityResource/CommentType/CommentTypeResourceTestBase.php
@@ -0,0 +1,77 @@
+      'description' => 'Camelids are large, strictly herbivorous animals with slender necks and long legs.',

    :P

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
FileSize
entityresource_provide-2843775-6.patch7.9 KB
interdiff-2843775-3-6.txt687 bytes

Fixed. Thanks @Wim Leers.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed c7d9cde to 8.4.x and bb95d1f to 8.3.x. Thanks!

  • alexpott committed c7d9cde on 8.4.x 
    Issue #2843775 by arshadcn, Wim Leers: EntityResource: Provide...

  • alexpott committed bb95d1f on 8.3.x 
    Issue #2843775 by arshadcn, Wim Leers: EntityResource: Provide...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.