Problem/Motivation

Drupal\system\Tests\System\UncaughtExceptionTest fails on php7.1 - see https://dispatcher.drupalci.org/job/drupalci_test_containers/730/testRep...

exception: [ArgumentCountError] Line 12 of core/modules/system/tests/modules/error_service_test/src/LonelyMonkeyClass.php:
Too few arguments to function Drupal\error_service_test\LonelyMonkeyClass::__construct(), 0 passed in /var/www/html/core/lib/Drupal/Component/DependencyInjection/Container.php on line 264 and exactly 1 expected

Likely to be a change to how errors are handled in PHP 7.1.

Proposed resolution

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 2842982-2.patch1.13 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

This is happening because of https://wiki.php.net/rfc/too_few_args which was implemented in PHP 7.1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Active » Needs review
FileSize
2842982-2.patch1.13 KB
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Reviewed & tested by the community

Looks great.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2842982-2.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs work » Reviewed & tested by the community

https://www.drupal.org/pift-ci-job/571518 is an unrelated test fail imo.

  • catch committed 3900e34 on 8.3.x 
    Issue #2842982 by alexpott: Fix Drupal\system\Tests\System\...

  • catch committed 28730b1 on 8.2.x 
    Issue #2842982 by alexpott: Fix Drupal\system\Tests\System\...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.