Problem/Motivation

The description and behavior is completely the same as in #2836827: Drupal.tableDrag: column span calculated wrongly for custom column, because `tabledrag.js` wasn't redesigned and mostly was migrated from 7.x.

Steps to reproduce

Proposed resolution

TBA

Remaining tasks

TBA

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 interdiff-2838945-8-11.txt5.5 KBBR0kEN
#11 drupal-tabledrag_custom_row-2838945-11.patch12.72 KBBR0kEN
#8 interdiff-2838945-6-8.txt3.06 KBBR0kEN
#8 drupal-tabledrag_custom_row-2838945-8.patch7.16 KBBR0kEN
#7 drupal-tabledrag_custom_row-2838945-6.patch9.02 KBBR0kEN
#6 drupal-tabledrag_custom_row-2838945-6.patch9.02 KBBR0kEN
#3 interdiff-2838945-2-3.txt5.5 KBBR0kEN
#3 drupal-tabledrag_custom_row-2838945-3.patch14.58 KBBR0kEN
#2 drupal-tabledrag_custom_row-2838945-2.patch9.31 KBBR0kEN
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

BR0kEN created an issue. See original summary.

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and for Propeople (now part of FFW), FFW commented
Status: Active » Needs review
FileSize
drupal-tabledrag_custom_row-2838945-2.patch9.31 KB

Patch with tests to reproduce the behavior.

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and for Propeople (now part of FFW), FFW commented
FileSize
drupal-tabledrag_custom_row-2838945-3.patch14.58 KB
interdiff-2838945-2-3.txt5.5 KB

Patch for fixing the issue.

The last submitted patch, 2: drupal-tabledrag_custom_row-2838945-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: drupal-tabledrag_custom_row-2838945-3.patch, failed testing.

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and for Propeople (now part of FFW), FFW commented
Status: Needs work » Needs review
FileSize
drupal-tabledrag_custom_row-2838945-6.patch9.02 KB

The same as in #2, but without .DS_Store binary file.

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and for Propeople (now part of FFW), FFW commented
FileSize
drupal-tabledrag_custom_row-2838945-6.patch9.02 KB

Try to put patch in queue for testing.

P.S. Why previous one is not there?

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and for Propeople (now part of FFW), FFW commented
FileSize
drupal-tabledrag_custom_row-2838945-8.patch7.16 KB
interdiff-2838945-6-8.txt3.06 KB

Removed custom JS errors catcher since GastonJS throws exceptions if they are exists on the page.

The last submitted patch, 7: drupal-tabledrag_custom_row-2838945-6.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 8: drupal-tabledrag_custom_row-2838945-8.patch, failed testing.

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and for Propeople (now part of FFW), FFW commented
Status: Needs work » Needs review
FileSize
drupal-tabledrag_custom_row-2838945-11.patch12.72 KB
interdiff-2838945-8-11.txt5.5 KB
BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and for Propeople (now part of FFW), FFW commented

Anybody, take a look at this please.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Issue tags: +Needs Review Queue Initiative, +Needs issue summary update

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge require as a guide.

This appears to still be relevant as a lot of the code is still the same.

Tagging for an IS update about the proposed solution.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue summary: View changes
Issue tags: +Bug Smash Initiative

This was a bugsmash daily target yesterday, discussed by larowlan and Lendude. It was agreed that this is valid and it is good to see that test coverage has been added.

There is concern that this is a duplicate. I did some searching and found a possible candidate, #997370: Tabledrag is not hiding the correct columns.

Edit: correct issue number of possible duplicate

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Assigned: BR0kEN » Unassigned
Status: Needs work » Closed (duplicate)
Related issues: +#997370: Tabledrag is not hiding the correct columns

In #bugsmash, lendude confirmed that this is a duplicate. Since that is the later issue, I am closing it in favor of the earlier one and moving credit.