Problem/Motivation

When re-saving configs in hook_update_n we have to trust the data, if we do not do it then there might errors during updates as the schema might not be up to date atm..

Proposed resolution

Trust the data when saving configs in system_update_8200 for sites which have not been updated yet.

Remaining tasks

Review & Commit.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2838370-2.patch577 byteshchonov
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hchonov created an issue. See original summary.

hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented
FileSize
2838370-2.patch577 bytes
hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented
Title: system_update_8200 is not trusting the date when resaving all configs but it should » system_update_8200 is not trusting the data when re-saving all configs but it should
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented

This is caused by #2625212: Add ConfigSchemaChecker to development.services.yml. Pasting part of my comment from there here, as well:

This has caused problems for upgrade functions which save config, so I think this should be rolled back.

At the very least we should check whether the config is explicitly trusted, and if so, we should not do anything.

Even then, though, this might be a risky change in case update functions (wrongly) do not trust data. See #2838370: system_update_8200 is not trusting the data when re-saving all configs but it should for an example of this.

I guess it should still be harmless to do this, but it is a bit weird to change this after this has run on most sites...

Status: Needs review » Needs work

The last submitted patch, 2: 2838370-2.patch, failed testing.

hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented
Status: Needs work » Needs review

Most but not all .. so it is better to fix than to leave it like this forever

Status: Needs review » Needs work

The last submitted patch, 2: 2838370-2.patch, failed testing.

stevekeiretsu’s picture

stevekeiretsu CreditAttribution: stevekeiretsu commented

hi

Attempting to update from 8.1.7 to 8.2.4 and database update fails:

system module
Update #8200

Failed: Drupal\Core\Config\ConfigNameException: Missing namespace in Config object name this. in Drupal\Core\Config\ConfigBase::validateName() (line 97 of /Users/myusername/Sites/mj2/core/lib/Drupal/Core/Config/ConfigBase.php).

Is this relevant, or am I totally on the wrong thread? This seems to be the only thing turning up googling "drupal system 8200" and the like. Applying the patch in this thread did not change anything, #2625212 does not seem to be applicable either as my (development.)services.yaml contains nothing about ConfigSchema in the first place.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lukasss’s picture

lukasss CreditAttribution: lukasss commented

#8 also for 8.3.3

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +Bug Smash Initiative

Is anyone experiencing this problem? If so, set the status to 'Active' and add a comment.

Thanks!

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

system_update_8200() is long gone, closing as outdated.