Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As requested by core committer @xjm at #2835604-14: BigPipe provides functionality, not an API: mark all classes & interfaces @internal and discussed in subsequent comments.
Comment | File | Size | Author |
---|---|---|---|
#9 | 2835758-8.patch | 23.31 KB | Wim Leers |
Comments
Comment #2
Wim LeersComment #3
effulgentsia CreditAttribution: effulgentsia at Acquia commentedIn core, we also have
RenderCacheInterface
, which is marked @internal, andLinkGeneratorInterface
, where each of its methods is marked @internal. Are we saying, we should in principle remove those interfaces too? Not this issue's scope; just curious if the same logic behind this patch applies broadly to core.Comment #4
Wim LeersI think you're right, those had interfaces created for the sake of creating interfaces. There was a time when we were pretty much blindly extracting interfaces out of classes. Doing it blindly was probably wrong. But now we can't change that.
We can still extract an interface later — that's equivalent with adding an API. But we can never remove an API. Hence this approach makes sense.
A different angle:
Comment #5
Fabianx CreditAttribution: Fabianx at Tag1 Consulting commentedRTBC - I agree, interfaces just for the sake of interfaces makes no sense.
Comment #6
Wim LeersPreferably, this gets committed after #2657684: Refactor BigPipe internals to allow a contrib module to extend BigPipe with the ability to stream anonymous responses and prime Page Cache for subsequent visits, because that one is much harder to reroll.
Comment #7
Wim Leers#2657684: Refactor BigPipe internals to allow a contrib module to extend BigPipe with the ability to stream anonymous responses and prime Page Cache for subsequent visits is in! Rebasing #2…
Comment #8
Wim LeersComment #9
Wim LeersOops, this is the right patch.
Comment #11
Wim LeersComment #12
alexpottCommitted eea7ce5 and pushed to 8.3.x. Thanks!
Comment #14
Wim LeersYay, this unblocked #2797169: Mark BigPipe as stable/non-experimental!