Views integration for block publishing status [#2834555]

Problem/Motivation

This is a follow-up to #2820848: Make BlockContent entities publishable. Views integration is needed for the block publishing status.

Proposed resolution

Pretty straight forward Views integration.

Remaining tasks

Implement everything.

User interface changes

None.

API changes

None.

Data model changes

None.

Comment	File	Size	Author
#5	interdiff.txt	1.59 KB	Manuel Garcia
#5	views_integration_for-2834555-5.patch	5.38 KB	Manuel Garcia
#5	8.3.x: PHP 5.5 & MySQL 5.5 21,326 pass
#3	custom-block-library-view.png	29.43 KB	Manuel Garcia
#3	views_integration_for-2834555-3.patch	3.79 KB	Manuel Garcia
#3	8.3.x: PHP 5.5 & MySQL 5.5 21,325 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

10 December 2016 at 19:25

dixon_ created an issue. See original summary.

Comment #2

dawehner

German

CreditAttribution: dawehner as a volunteer and at Chapter Three commented 11 December 2016 at 08:29

IMHO this will be added automatically, without any further work.

Comment #3

Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer commented 11 December 2016 at 11:07

Status:

Active

» Needs review

File	Size
views_integration_for-2834555-3.patch	3.79 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,325 pass, 1 fail
custom-block-library-view.png	29.43 KB

I think @dawehner is correct, I've been testing the patch on #2820848: Make BlockContent entities publishable, and playing around with the block_content view, and I am able to show the Publishing status field, and add an exposed filter which works properly, so we may not need to do anything here after all.

Displaying True / False as the options for the exposed filter may not very user friendly, though I'm not sure this should be improved in core.

One thing we could use this issue for is actually including the published column and exposed filter to this view? Just in case we do, or for other people who want to test this, the attached patch adds the published column and exposed filter to /admin/structure/block/block-content.

Custom Block library with published status

Comment #4

11 December 2016 at 11:56

Status:

Needs review

» Needs work

The last submitted patch, 3: views_integration_for-2834555-3.patch, failed testing.

Comment #5

Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer commented 11 December 2016 at 12:34

Status:

Needs work

» Needs review

File	Size
views_integration_for-2834555-5.patch	5.38 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,326 pass
interdiff.txt	1.59 KB

Fixing failing test

Comment #6

Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer commented 11 December 2016 at 14:07

OK this looks like it's more suited for #2834546: UI for publishing/unpublishing block_content blocks so I'm going to take this work over there.

Comment #7

Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer commented 11 December 2016 at 14:34

4 files were hidden/shown/deleted

File	Size
views_integration_for-2834555-3.patch	3.79 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,325 pass, 1 fail
custom-block-library-view.png	29.43 KB
views_integration_for-2834555-5.patch	5.38 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,326 pass
interdiff.txt	1.59 KB

Please ignore my last patches here, made a lot more progress on #2834546: UI for publishing/unpublishing block_content blocks.

On there admittedly there I did add a bit of views integration (adding the bulk operations actions for publishing/unpublishing blocks), but well its just part of the whole UI of this so why keep them separate...

I think we could just close this and continue to work on there.