This is a follow-up to: #2745619: [policy, no patch] Which core entities get revisions?
Problem/Motivation
From #2745619-18: [policy, no patch] Which core entities get revisions?:
On the one hand, I can see some value in them being revisionable. You could then build up a time machine of what was at a particular feed url during a particular fetch time of that URL.
On the other hand, I can also see it as problematic. Because if Aggregator feeds are not revisionable, then you can edit a feed entity and change its URL. Now all of your old item entities contain content that potentially never existed at the new feed URL. But those items only reference the feed entity by its ID, not its URL, so you've lost the information about which feed URL actually provided the contents for those old items. This just seems like it would lead to a complete mess.
So, if we want to make aggregator items revisionable, then I think we need to somehow make them store the feed URL that was fetched at that time. Whether that's by adding that URL as a base field to the item entity, or whether it's by making feed entities revisionable, and making item revisions reference the feed revision.
Or, we can do as #14 suggests, and not solve this in Aggregator, but punt the use case to the Feeds module.
Proposed resolution
None, yet.
Remaining tasks
Discuss and decide.
User interface changes
TBD.
API changes
TBD.
Data model changes
TBD.
Comments
Comment #2
dixon_Comment #13
quietone CreditAttribution: quietone at PreviousNext commentedThe
aggregator
module has been removed from Core in10.0.x-dev
and now lives on as a contrib module. Issues in the Core queue about theaggregator
module, like this one, have been moved to the contrib module queue.Comment #14
larowlanWe're in 'keep the lights on mode' now this is out of core.