The assert message checking for the success message in drupalLogin() uses the placeholder 'name' instead of '%name'. This leads to an error when the test fails (or when the message is displayed for any other reason.)

CommentFileSizeAuthor
#8 2832052-8.patch1.25 KBamoebanath
#6 2832052-6.patch1.14 KBamoebanath
#2 2832052-2--drupalLogin_assert_message.patch1.16 KBdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Active » Needs review
FileSize
2832052-2--drupalLogin_assert_message.patch1.16 KB

This fixes the bug, and also two deprecated method calls in the same line.

Chi’s picture

Chi CreditAttribution: Chi commented
Priority: Normal » Minor
Status: Needs review » Needs work
Issue tags: +Needs reroll

The following code can be used to reproduce the error.

$user = $this->drupalCreateUser();
$user->block()->save();
$this->drupalLogin($user);
+++ b/core/tests/Drupal/Tests/BrowserTestBase.php
@@ -8,6 +8,7 @@
 use Drupal\Component\Utility\SafeMarkup;

This statement becomes unused.

Chi’s picture

Chi CreditAttribution: Chi commented
Issue tags: +Novice
amoebanath’s picture

amoebanath CreditAttribution: amoebanath commented
Assigned: Unassigned » amoebanath
amoebanath’s picture

amoebanath CreditAttribution: amoebanath at ComputerMinds commented
Assigned: amoebanath » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll, -Novice
FileSize
2832052-6.patch1.14 KB

Re-rolled!

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs review » Needs work

@amoebanath, since we remove SafeMarkup can you check if its use statement is still needed?

amoebanath’s picture

amoebanath CreditAttribution: amoebanath at ComputerMinds commented
Status: Needs work » Needs review
FileSize
2832052-8.patch1.25 KB

Yep, don't need it. New patch!

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed 8ec7fdc on 8.3.x 
    Issue #2832052 by amoebanath, drunken monkey: BrowserTestBase::...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x, thanks!

  • catch committed 8ec7fdc on 8.4.x 
    Issue #2832052 by amoebanath, drunken monkey: BrowserTestBase::...

  • catch committed 8ec7fdc on 8.4.x 
    Issue #2832052 by amoebanath, drunken monkey: BrowserTestBase::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.