Problem/Motivation

SimpleTestBrowserTest::testTestingThroughUI() executes PHPUnit tests through the UI. It reuses other tests such as BrowserTestBaseTest. As soon as BrowserTestBaseTest grows bigger this test becomes unstable and randomly fails.

Proposed resolution

Use a dedicated example browser test which does nothing but pass. That way any additions to BrowserTestBaseTest do not interfere with the success rate of SimpleTestBrowserTest.

CommentFileSizeAuthor
#2 simpletest-2820442-2.patch1.48 KBklausi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klausi created an issue. See original summary.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Active » Needs review
FileSize
simpletest-2820442-2.patch1.48 KB

Patch.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

This works for me, thank you!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented

Ideally we should understand where this random failure was coming from in the first place.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

I agree with @dawehner about finding the cause - but I also think the change makes sense.

Committed and pushed e276eeb to 8.3.x and 131144b to 8.2.x. Thanks!

  • alexpott committed e276eeb on 8.3.x 
    Issue #2820442 by klausi: SimpleTestBrowserTest has random fails when...

  • alexpott committed 131144b on 8.2.x 
    Issue #2820442 by klausi: SimpleTestBrowserTest has random fails when...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.