Currently the rdf.module hook_preprocess_node() implementation renders the added metadata using drupal_render() and other modules are not be able to alter this metadata.

Since we are using twig to print this variable, removing the call to drupal_render() does not have any effect on existing sites.

CommentFileSizeAuthor
#15 rdf.module-do_not_render_metadata-2819695-15-D8.patch690 bytesSchnWalter
#6 rdf.module-do_not_render_metadata-2819695-6-D8.patch797 bytesSchnWalter
#2 rdf.module-do_not_render_metadata-2819695-2-D8.patch783 bytesSchnWalter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SchnWalter created an issue. See original summary.

SchnWalter’s picture

SchnWalter CreditAttribution: SchnWalter as a volunteer and commented
Assigned: SchnWalter » Unassigned
Status: Active » Needs review
FileSize
rdf.module-do_not_render_metadata-2819695-2-D8.patch783 bytes

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

SchnWalter’s picture

SchnWalter CreditAttribution: SchnWalter as a volunteer and commented
FileSize
rdf.module-do_not_render_metadata-2819695-6-D8.patch797 bytes
swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Yes please, been bitten by this at the moment.
It's a trivial fix, and helps people who want to alter the metadata element in a later preprocess function.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

This is a good change but I can conceive of sites with workarounds - i.e. a find and replace on the string. As per https://www.drupal.org/core/d8-bc-policy variables passed to preprocess are allowed to change. But I do think we should have a change record to inform themers that this variable is changing from a string to a render array.

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented

Right, makes sense, I'll make a change record over the weekend, I have example code to account for both use cases.

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Status: Needs work » Needs review
Issue tags: -Needs change record

Change record at https://www.drupal.org/node/2959337

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community

The change record is very detailed and doesn't seem to miss any information. Since that was the only thing missing in #8, this can go back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

I'm sorry that i missed this before but i think it's worth adding a test so we don't regress.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

SchnWalter’s picture

SchnWalter CreditAttribution: SchnWalter as a volunteer and commented
FileSize
rdf.module-do_not_render_metadata-2819695-15-D8.patch690 bytes

Re-rolling patch against 8.8.x

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Project: Drupal core » Resource Description Framework (RDF)
Version: 9.5.x-dev » 2.x-dev
Component: rdf.module » Code

This appears to possibly still be valid.

FYI RDF is being moved to https://www.drupal.org/project/rdf and out of core so moving the ticket over there.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Postponed (maintainer needs more info)

Wondering if this is still an issue as the issue appears to be in the rdf_preprocess_comment not node.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

If still a valid issue please reopen