Problem/Motivation
Original IS - Currently Actions module allow to create entities only for plugins that implements PluginFormInterface. This is confusing. In common case action plugin can have zero configuration and as result no form for this.
Steps to reproduce
Create a new Action plugin that does not implement PluginFormInterface
Enable the actions module
Go to the action configuration page
Verify the new action does not display as an option to create a new action.
Proposed resolution
Remove check if the action implements PluginFormInterface
Remaining tasks
CR snippet.
User interface changes
Actions that do not implement PluginFormInterface
will now be able to be created on the Actions configuration page.
API changes
None
Data model changes
None
Release notes snippet
Still to do
Comment | File | Size | Author |
---|---|---|---|
#22 | interdiff-11-22.txt | 1.45 KB | DanielVeza |
#22 | action_plugin_create_condition-2815301-22.patch | 1.75 KB | DanielVeza |
Comments
Comment #2
Chi CreditAttribution: Chi commentedComment #5
Chi CreditAttribution: Chi commentedComment #6
Chi CreditAttribution: Chi commentedComment #7
Chi CreditAttribution: Chi commentedComment #10
andypostComment #11
kostyashupenkoComment #20
DanielVezaI think this totally makes sense. Even more so when #2815297: Actions module should allow to edit and remove non-configurable actions lands. For example, if the default "Unpublish taxonomy term" action is deleted, without this patch it can't be added back in via the UI.
I don't think we need the ... at the end of this. Is there any reason thats needed that I might be missing?
This needs tests too. It still applies to 10.1.x, I've queued a 10.x.1 test run against the latest patch
Comment #21
Chi CreditAttribution: Chi commentedThe ellipsis has been removed in upstream long time ago. See #2763433: Hardcoded ellipsis in actions configuration form. The patch needs to be updated accordingly.
Comment #22
DanielVezaRemoved the ellipsis and added a test for this. I used an existing action from the user module for this to stop us needing to create a new test module with one action in it. Happy to create a new module if thats preferred. Just feels like more code to maintain for minimal benefit.
Comment #23
smustgrave CreditAttribution: smustgrave at Mobomo commentedSeems like such a feature will require a change record so others will know they can now create plugins without implementing PluginFormInterface
Would be nice to have an issue summary update that the proposed solution is to remove the check for PluginFormInterface completely. But not going to tag for it.
Comment #24
DanielVezaComment #25
DanielVezaUpdated the IS and added a change record - Leaving the tag so it can be reviewed.
https://www.drupal.org/node/3340772
Comment #26
smustgrave CreditAttribution: smustgrave at Mobomo commentedChange record looks good to me.
Will move this along
Comment #27
andypostrequeued as commited #2815297: Actions module should allow to edit and remove non-configurable actions
Comment #29
catchCommitted/pushed to 10.1.x, thanks!
Comment #31
quietone CreditAttribution: quietone at PreviousNext commentedPublished the CR.