As discussed previously in #2775587: Mark BigPipe as beta-level stability (instead of alpha), once #2657684: Refactor BigPipe internals to allow a contrib module to extend BigPipe with the ability to stream anonymous responses and prime Page Cache for subsequent visits lands, Fabianx and I want to mark BigPipe stable/non-experimental

CommentFileSizeAuthor
#7 2797169-7.patch535 bytesWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#2835604: BigPipe provides functionality, not an API: mark all classes & interfaces @internal

Also, before marking BigPipe stable, we should do #2835604: BigPipe provides functionality, not an API: mark all classes & interfaces @internal, to clearly establish expectations. Quoting the relevant portion:

Except that's the thing: the BigPipe module provides no API, it only provides functionality.. BigPipe simply uses the Render API and the request processing system's APIs.

We guarantee BC for its functionality/behavior, but not for the exact code implementation details.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: [PP-1] Mark BigPipe as stable/non-experimental » [PP-2] Mark BigPipe as stable/non-experimental

That makes this postponed on both of those issues.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: [PP-2] Mark BigPipe as stable/non-experimental » [PP-1] Mark BigPipe as stable/non-experimental

#2835604: BigPipe provides functionality, not an API: mark all classes & interfaces @internal was committed.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Related issues: +#2835758: Remove BigPipeInterface and move all of its docs to the implementation

Hurray, #2657684: Refactor BigPipe internals to allow a contrib module to extend BigPipe with the ability to stream anonymous responses and prime Page Cache for subsequent visits landed! This was the truly big blocker.

However, I think it's best to also wait for #2835758: Remove BigPipeInterface and move all of its docs to the implementation to land, which was a follow-up filed for #2835604: BigPipe provides functionality, not an API: mark all classes & interfaces @internal.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: [PP-1] Mark BigPipe as stable/non-experimental » Mark BigPipe as stable/non-experimental
Status: Postponed » Active

Woot, #2835758: Remove BigPipeInterface and move all of its docs to the implementation is in!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Active » Needs review
FileSize
2797169-7.patch535 bytes
effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs release manager review

Yay! Looks great to me, but leaving to a release manager to commit.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented

I raised this to Major in #8 because https://www.drupal.org/core/experimental#requirements includes a bullet point about experimental modules generally needing to become stable within 2 minor releases. BigPipe was added to core for 8.1, so by that policy should become stable by 8.3. Very nice to see that happening!

xjm credited Fabianx.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

  • xjm committed 4cc325f on 8.2.x 
    Issue #2797169 by Wim Leers, Fabianx: Mark BigPipe as stable/non-...

  • xjm committed df540a9 on 8.2.x 
    Revert "Issue #2797169 by Wim Leers, Fabianx: Mark BigPipe as stable/non...

  • xjm committed 54f3839 on 8.3.x 
    Issue #2797169 by Wim Leers, Fabianx: Mark BigPipe as stable/non-...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs release manager review +8.3.0 release notes

All the requirements for the module to be stable have been met, and the technical debt has been well-managed. Now that #2657684: Refactor BigPipe internals to allow a contrib module to extend BigPipe with the ability to stream anonymous responses and prime Page Cache for subsequent visits and #2835758: Remove BigPipeInterface and move all of its docs to the implementation are in, let's do this!

Committed to 8.3.x (the 8.2.x commit was an accident and reverted). I'm pleased that we have the first experimental module to become stable!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.