Problem/Motivation

* PHPUnit defines ::runTest
* When LanguageUILanguageNegotiationTest extends Phpunit, as part of the BrowserTestBase conversion, its signature conflicts with the one from phpunit

Proposed resolution

Use doRunTest as new method name.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 rename-2795615-4.patch4.8 KBGoZ
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Related issues: +#2794285: [meta] Add backwards compatibility layer to browsertestbase to ease conversion from webtestcase
YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: +PHPUnit
GoZ’s picture

GoZ CreditAttribution: GoZ at Centarro commented
Status: Active » Needs review
FileSize
rename-2795615-4.patch4.8 KB

Here it is

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Perfect! Thank you !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 441357f and pushed to 8.3.x. Thanks!

  • alexpott committed 441357f on 8.3.x 
    Issue #2795615 by GoZ: Rename LanguageUILanguageNegotiationTest::runTest...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.