Problem/Motivation

Its not a simpletest, so this test class really doesn't have to live within simpletest.

Proposed resolution

Move it

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 interdiff-2784677-4-6.txt657 bytesGoZ
#6 move-2784677-6.patch3.88 KBGoZ
#4 move-2784677-4.patch3.85 KBGoZ
#2 move-2784677-2.patch3.67 KBGoZ
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

GoZ’s picture

GoZ CreditAttribution: GoZ at Centarro commented
Status: Active » Needs review
FileSize
move-2784677-2.patch3.67 KB

I update namespace to correspond to current file location.

Maybe should we remove the simpletest @group from the file to ? But do we remove it or replacing by something else ?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented

That was super quick!

Maybe should we remove the simpletest @group from the file to ? But do we remove it or replacing by something else ?

Good question, maybe use 'browsertestbase' instead?

GoZ’s picture

GoZ CreditAttribution: GoZ at Centarro commented
FileSize
move-2784677-4.patch3.85 KB

Patch only replace @group simpletest by browsertestbase.

Status: Needs review » Needs work

The last submitted patch, 4: move-2784677-4.patch, failed testing.

GoZ’s picture

GoZ CreditAttribution: GoZ at Centarro commented
Status: Needs work » Needs review
FileSize
move-2784677-6.patch3.88 KB
interdiff-2784677-4-6.txt657 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Nice, thanks a lot!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Sure why not? Committed and pushed 4282851 to 8.3.x and 9d70c6a to 8.2.x. Thanks!

Committed to 8.2.x since this is a test only change and to keep the branches aligned.

  • alexpott committed 4282851 on 8.3.x 
    Issue #2784677 by GoZ: Move core/modules/simpletest/tests/src/Functional...

  • alexpott committed 9d70c6a on 8.2.x 
    Issue #2784677 by GoZ: Move core/modules/simpletest/tests/src/Functional...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.