Drupal always displays notice/warning/error messages on the screen during update.php, even when the site is configured not to [#2767663]

If a site has been configured to display PHP notice/warning/error messages in the logs only (not on the screen), Drupal should respect that setting. But currently it ignores that on update.php and always displays them on the screen.

This can cause confusion for people who are not used to seeing such messages in the admin UI but then suddenly see them when they update to a new Drupal version and run update.php. I suspect (but am not sure) that this kind of confusion is evident in some of the comments at https://www.drupal.org/node/2487215.

Before I looked through Git history to figure out when/why this behavior was originally added, my guess was that it was probably added somewhere around 2004 and the likely reason was that update.php wasn't capable of sending messages to the logs at that time. I wasn't 100% correct, but pretty close :) #54003: Watchdog not logging update errors

This behavior is no longer needed, so it should just be removed.

Comment	File	Size	Author
#11	2767663-11.patch	2.04 KB	aerozeppelin
#11	7.x: PHP 5.3 & MySQL 5.5 2,025 pass, 4 fail
#11	interdiff-2767663-8-11.txt	1001 bytes	aerozeppelin
#8	2767663-8.patch	1.97 KB	aerozeppelin
#8	7.x: PHP 5.3 & MySQL 5.5 1,995 pass, 53 fail
#8	test-only-fail-2767663-8.patch	1.19 KB	aerozeppelin
#8	7.x: PHP 5.3 & MySQL 5.5 2,023 pass, 11 fail
#8	interdiff-2767663-4-8.txt	1.19 KB	aerozeppelin
#4	2767663-4.patch	1.18 KB	aerozeppelin
#4	7.x: PHP 5.3 & MySQL 5.5 2,023 pass PHP 5.5 & MySQL 5.5 2,023 pass
#2	messages-displayed-during-update-php-2767663-2.patch	1.18 KB	David_Rothstein
#2	8.2.x: PHP 5.5 & MySQL 5.5 18,648 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

16 July 2016 at 21:34

David_Rothstein created an issue. See original summary.

Comment #2

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented 16 July 2016 at 21:36

Status:	Active	» Needs review
Issue tags:		+Needs backport to D7

File	Size
messages-displayed-during-update-php-2767663-2.patch	1.18 KB
8.2.x: PHP 5.5 & MySQL 5.5 18,648 pass

Here is a patch - untested, but pretty simple.

The Drupal 7 version of this can just remove the MAINTENANCE_MODE check entirely, but since Drupal 8 is also ensuring that messages are always displayed to the screen during install.php, I guess we should not alter that part of the behavior here.

Comment #3

16 July 2016 at 21:36

Version:

8.2.x-dev

» 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #4

aerozeppelin CreditAttribution: aerozeppelin commented 17 August 2016 at 17:27

File	Size
2767663-4.patch	1.18 KB
7.x: PHP 5.3 & MySQL 5.5 2,023 pass PHP 5.5 & MySQL 5.5 2,023 pass

Fix for D7 as per the comments in #2.

Comment #5

17 August 2016 at 17:39

Status:

Needs review

» Needs work

The last submitted patch, 4: 2767663-4.patch, failed testing.

Comment #6

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented 12 September 2016 at 14:33

Status:

Needs work

» Needs review

Comment #7

daffie CreditAttribution: daffie commented 12 September 2016 at 14:56

Status:	Needs review	» Needs work
Issue tags:		+Needs tests

I think that this patch needs some tests.

Comment #8

aerozeppelin CreditAttribution: aerozeppelin at California State University San Bernardino commented 13 September 2016 at 18:09

Status:

Needs work

» Needs review

File	Size
interdiff-2767663-4-8.txt	1.19 KB
test-only-fail-2767663-8.patch	1.19 KB
7.x: PHP 5.3 & MySQL 5.5 2,023 pass, 11 fail
2767663-8.patch	1.97 KB
7.x: PHP 5.3 & MySQL 5.5 1,995 pass, 53 fail

Added a failing test. Looking for someone to take it forward.

Comment #9

13 September 2016 at 19:00

Status:

Needs review

» Needs work

The last submitted patch, 8: 2767663-8.patch, failed testing.

Comment #10

13 September 2016 at 19:01

The last submitted patch, 8: test-only-fail-2767663-8.patch, failed testing.

Comment #11

aerozeppelin CreditAttribution: aerozeppelin at California State University San Bernardino commented 14 September 2016 at 17:23

Status:

Needs work

» Needs review

File	Size
interdiff-2767663-8-11.txt	1001 bytes
2767663-11.patch	2.04 KB
7.x: PHP 5.3 & MySQL 5.5 2,025 pass, 4 fail

Fix for failing tests on #8.

Comment #12

14 September 2016 at 17:35

Status:

Needs review

» Needs work

The last submitted patch, 11: 2767663-11.patch, failed testing.

Comment #13

daffie CreditAttribution: daffie commented 14 September 2016 at 17:39

5 files were hidden/shown/deleted

File	Size
messages-displayed-during-update-php-2767663-2.patch	1.18 KB
8.2.x: PHP 5.5 & MySQL 5.5 18,648 pass
2767663-4.patch	1.18 KB
7.x: PHP 5.3 & MySQL 5.5 2,023 pass PHP 5.5 & MySQL 5.5 2,023 pass
interdiff-2767663-4-8.txt	1.19 KB
test-only-fail-2767663-8.patch	1.19 KB
7.x: PHP 5.3 & MySQL 5.5 2,023 pass, 11 fail
2767663-8.patch	1.97 KB
7.x: PHP 5.3 & MySQL 5.5 1,995 pass, 53 fail

Quick review:

+++ b/modules/simpletest/tests/upgrade/upgrade.test
@@ -491,6 +491,24 @@ class BasicStandardUpdatePath extends UpdatePathTestCase {
+    module_enable(array('poll'));

I do not think we have a module called poll in D8 core any more.

Comment #14

aerozeppelin CreditAttribution: aerozeppelin at California State University San Bernardino commented 16 September 2016 at 16:06

The above patch was meant for D7 :D

Comment #15

16 September 2016 at 16:06

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #16

16 September 2016 at 16:06

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #17

16 September 2016 at 16:06

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #18

16 September 2016 at 16:06

Version:

8.6.x-dev

» 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #19

16 September 2016 at 16:06

Version:

8.7.x-dev

» 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #20

16 September 2016 at 16:06

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #21

16 September 2016 at 16:06

Version:

8.9.x-dev

» 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #22

16 September 2016 at 16:06

Version:

9.1.x-dev

» 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Comment #23

16 September 2016 at 16:06

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #24

16 September 2016 at 16:06

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #25

16 September 2016 at 16:06

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #26

16 September 2016 at 16:06

Version:

9.5.x-dev

» 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #27

16 September 2016 at 16:06

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.