Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klausi created an issue. See original summary.

klausi’s picture

naveenvalecha’s picture

Status: Needs review » Reviewed & tested by the community

let's do it.
Thanks!

dawehner’s picture

+1

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed bd27a538efe033eb2218da40c9544d648fc91984 to 8.2.x and a266f04 to 8.1.x. Thanks!

Added to both branches because out of sync tests are a pain.

  • alexpott committed bd27a53 on 8.2.x
    Issue #2755991 by klausi: Convert web tests to browser tests for...

  • alexpott committed a266f04 on 8.1.x
    Issue #2755991 by klausi: Convert web tests to browser tests for...

  • xjm committed a9938c9 on 8.1.x
    Revert "Issue #2755991 by klausi: Convert web tests to browser tests for...

  • xjm committed 39a382b on 8.2.x
    Revert "Issue #2755991 by klausi: Convert web tests to browser tests for...
xjm’s picture

Status: Fixed » Postponed

This issue introduced a random fail similar to #2776269: High random fail rate in BTB forum tests on Postgres (especially, but not only, with PHP7) but at a lower rate. E.g. see:
https://www.drupal.org/pift-ci-job/397411

Telephone.Drupal\Tests\telephone\Functional\TelephoneFieldTest
✗	
testTelephoneField
fail: [Other] Line 47 of core/modules/telephone/tests/src/Functional/TelephoneFieldTest.php:
Drupal\Tests\telephone\Functional\TelephoneFieldTest::testTelephoneField
Behat\Mink\Exception\ExpectationException: The string "" was not found anywhere in the HTML response of the current page.

/var/www/html/vendor/behat/mink/src/WebAssert.php:770
/var/www/html/vendor/behat/mink/src/WebAssert.php:325
/var/www/html/core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php:188
/var/www/html/core/modules/telephone/tests/src/Functional/TelephoneFieldTest.php:90
✗	
rupal\Tests\telephone\Functional\TelephoneFieldTe
fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-1700.xml:
PHPunit Test failed to complete
✗	
nkno
fail: [run-tests.sh check] Line 0 of :
FATAL Drupal\Tests\telephone\Functional\TelephoneFieldTest: test runner returned a non-zero error code (2).

Postponing as per #2737805-32: Convert web tests to browser tests for forum module. :(

  • alexpott committed bd27a53 on 8.3.x
    Issue #2755991 by klausi: Convert web tests to browser tests for...
  • xjm committed 39a382b on 8.3.x
    Revert "Issue #2755991 by klausi: Convert web tests to browser tests for...

  • alexpott committed bd27a53 on 8.3.x
    Issue #2755991 by klausi: Convert web tests to browser tests for...
  • xjm committed 39a382b on 8.3.x
    Revert "Issue #2755991 by klausi: Convert web tests to browser tests for...

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

Status: Postponed » Needs review
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Back to RTBC

klausi’s picture

Status: Reviewed & tested by the community » Needs review

We need to wait for #2771547: In Browser and FunctionalJavascript tests SIMPLETEST_USER_AGENT cookie needs to be set every 5 seconds, otherwise we will get random fails on Postgres again.

klausi’s picture

Status: Needs review » Reviewed & tested by the community

That got resolved, back to RTBC.

alexpott’s picture

Status: Reviewed & tested by the community » Postponed
klausi’s picture