Problem/Motivation

#2575725: Run PHPunit tests one at a time via UI to avoid exception when selecting too many added a BC layer than can be removed.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 2748967_12.patch1.19 KBMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Active
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Title: Remove BC support in simpletest_run_tests() » Trigger E_USER_DEPRECATED for BC support in simpletest_run_tests()
Version: 9.x-dev » 8.3.x-dev

Slightly re-purposing this to trigger a deprecation notice.

We should then be able to automate or at least semi-automate removing code paths like this in 9.x

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Issue tags: +@deprecated, +phpunit initiative
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Related issues: +#2234479: Deprecate hook_test_* hooks in simpletest

simpletest_run_tests() triggers hook_test_group_started(). #2234479: Deprecate hook_test_* hooks in simpletest

We also have a deprecation policy for simpletest happening in #2866082: [Plan] Roadmap for Simpletest

We really should deprecate all the batch-related tests runner pieces at the same time, but we'll also need to maintain them a little bit until D9.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Related issues: +#2750461: Remove Simpletest UI because we don't want to maintain a graphical test runner

simpletest_run_tests() is only ever touched by the UI form hander, and never directly by a cli/phpunit test run. So calling @trigger_error() wouldn't accomplish much, beyond causing a deprecation error when we test the form.

If we're deprecating the UI form, then we should figure out a way to implement #2750461: Remove Simpletest UI because we don't want to maintain a graphical test runner so that people who use it see a warning that it's about to go away.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented

@Mile23
I'm wondering whether we have to treat simpletest_run_tests() as some form of API. Theoretically someone else could have used this function to build a custom simletest UI, even realistically this isn't the case.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Active » Needs review
Issue tags: +Needs change record
FileSize
2748967_12.patch1.19 KB

OK, sounds reasonable. I just think we're going to have trouble because we can't do @group legacy in Simpletest tests.

Status: Needs review » Needs work

The last submitted patch, 12: 2748967_12.patch, failed testing. View results

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Closed (duplicate)
Related issues: +#3110862: Remove simpletest module from core

This was done in #3110862: Remove simpletest module from core. Closing as a duplicate