Problem/Motivation

A field (on a content type) can be configured to allow users to translate this field or not by ticking Users may translate this field.
If the Allowed number of values is set to "1", then the label of that field is changed on a translation form with an added (all languages) to indicate that a change in this field will affect all languages.
But when the allowed number of values is set to any other number or to unlimited, then this hint is missing.

In this screen shot, the first taxonomy reference allows one value, the second multiple. The hint (alle talen/all languages) is only displayed in the first.

Proposed resolution

Add (all languages) to the display of multiple values as well.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 add_field_all_languages_on_field_multiple.patch698 bytestoufik74
screenshot-fpp nightingale 2016-05-30 22-38-25.png11.29 KBifrik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ifrik created an issue. See original summary.

toufik74’s picture

toufik74 CreditAttribution: toufik74 as a volunteer and commented
Status: Active » Fixed
FileSize
add_field_all_languages_on_field_multiple.patch698 bytes

Hi, you can find a patch wich fix this bug.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Version: 8.1.1 » 8.4.x-dev
Status: Fixed » Needs review

Hi micka2607,

thanks for providing a patch. You should set the status to "Needs review". That will trigger the automatic testing and reviewing by others. Once it has been reviewed, one of the core committers can commit it, and then it will be set to "Fixed", meaning that it is fixed in the code itself.

Status: Needs review » Needs work

The last submitted patch, 2: add_field_all_languages_on_field_multiple.patch, failed testing.

joachim’s picture

joachim CreditAttribution: joachim at Torchbox commented
Title: (all languages) not displayed for multiple values of a field » '(all languages)' translatability clue not displayed for multiple-valued fields
Priority: Normal » Major

Upping to major, as this surely causes confusion in end-users who could change a value in one translation, and then not understand why the change shows up in another.

The patch needs work, as I don't think it's doing the right thing.

Here's the current code with my comments on what's going wrong:

    // Update #title attribute for all elements that are allowed to have a
    // #title attribute according to the Form API Reference. The reason for this
    // check is because some elements have a #title attribute even though it is
    // not rendered; for instance, field containers.
    if (isset($element['#type']) && isset($fapi_title_elements[$element['#type']]) && isset($element['#title'])) {

      # We don't get here for the main element, because the field multi-value widget doesn't have a #type,
      # but a #theme = field_multiple_value_form.

      # We might get here for child elements, depending on their #type (but not for entityreference fields, 
      # as 'entity_autocomplete' is not in the the $fapi_title_elements list).
      # However, the field_multiple_value_form theming doesn't show any titles on child elements.

      $element['#title'] .= $suffix;
    }
    // If the current element does not have a (valid) title, try child elements.
    elseif ($children = Element::children($element)) {

      # We DO get here for the main element, and recurse down into our child elements.

      foreach ($children as $delta) {
        $this->addTranslatabilityClue($element[$delta], $suffix);
      }
    }
    // If there are no children, fall back to the current #title attribute if it
    // exists.
    elseif (isset($element['#title'])) {

      # We don't get here, as we passed the condition for the second block.

      $element['#title'] .= $suffix;
    }

I think the best fix might be to expand the conditions for the first block, and add cases for elements that are themed rather than having a form element type.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.