Decimal separator and decimals settings ignored when aggregating decimal fields

Thanks for your report. Moving to the right component.

Testing on 8.1.2. Tested also on 8.0.x versions.
This is the problem on views since the first stable release of drupal 8.
This problem occurs when aggregation is set on SUM or AVERAGE aggregation function.

Setting this to unassigned for now. Posted the screenshot of the issue.

Well, noone had time/motivation to work on this issue :)

Think it is a bit strange if it not is anyone that is interested to make the settings in Views to be right than using aggregate option.

Well, what about you?

Here is a quick outline of thoughts:

• \Drupal\views\Plugin\views\field\NumericField::buildOptionsForm has support for float fields, using $this->definition['float']
• In \Drupal\views\Plugin\views\display\DisplayPluginBase::getHandlers we initialize the fields, and provide a special way for aggregated fields
• \Drupal\views\Plugin\views\query\Sql::getAggregationInfo defines these special fields
• We could somehow let those special fields define a definition for those fields

This should be totally doable in a BC compatible way.

Unassigning myself for now, but I'll be back.

It seems like this piece of code is responsible for the bad output.

function template_preprocess_views_view_field(&$variables) {
  $variables['output'] = $variables['field']->advancedRender($variables['row']);
}

It seems to me "Precision should be set."

$this->options['set_precision']

or else you'll get:

$remainder = abs($value) - intval(abs($value));
      $value = $value > 0 ? floor($value) : ceil($value);
      $value = number_format($value, 0, '', $this->options['separator']);
      if ($remainder) {
        // The substr may not be locale safe.
        $value .= $this->options['decimal'] . substr($remainder, 2);
      }

A temporary solution could be:

/**
 * Prepares variables for views field templates.
 *
 * Default template: views-view-field.html.twig.
 *
 * @param array $variables
 *   An associative array containing:
 *   - field: The field handler object for the current field.
 *   - row: Object representing the raw result of the SQL query for the current
 *     field.
 *   - view: Instance of the ViewExecutable object for the parent view.
 */
function THEME_preprocess_views_view_field(&$variables) {
  $variables['field']->options['set_precision'] = TRUE;
  $variables['field']->options['precision'] = 2;
  $variables['output'] = $variables['field']->advancedRender($variables['row']);
}

The solution if we can fix this

ISSUE
In "NumericField.php"

  public function buildOptionsForm(&$form, FormStateInterface $form_state) {
    if (!empty($this->definition['float'])) {

This is actually not set if your field is a decimal or a float. :/ (I think it should be ?)
and this allows you to set the precision and other configuration via the views interface and thus resolving the issue. I could put the if switch in comment, but I don't know how it should exactly work.

And I don't know where "definition" is set actually :/

Solved the number of decimals with {{ field_myfield|round(2, 'common') }}. With a little bit more of Twig perhaps I can manage to also make a comma instead of a point.

Try using Twig's "number_format" filter instead of "round":
{{ field_myfield|number_format(2, '.', ',') }}

Arguments:

• decimal: The number of decimal points to display
• decimal_point: The character(s) to use for the decimal point
• thousand_sep: The character(s) to use for the thousands separator

From: http://twig.sensiolabs.org/doc/2.x/filters/number_format.html

If aggregation is enabled then views field definition will be overriden here \Drupal\views\Plugin\views\query\Sql::getAggregationInfo() (See screenshot for more details).

If you want to have an ability to set "Precision", "Thousands marker", "Decimal point" then you need to enable additional options for the float numbers. You can do this by adding "float" option to your field definition. This can be done at least on hook_views_data_alter().

Here is an example:

function MYMODULE_views_data_alter(array &$data) {
  $data['node_field_data']['field_amount']['field']['float'] = TRUE;
}

Dear @nikita_tt,
for me works this:

$data['node__field_test']['field_test']['field']['float'] = TRUE;

Anyway, I think it is just a workaround.

Updated the title a bit to make it clearer what this is about

I tried controlling the decimal precision by using twig in a custom text field, such as the following:

{{ field_value|round }}
{{ field_value|round(1, 'common') }}

But none of these worked. They all returned a 0.

On a side note, no other twig math functions worked either, even for basic arithmetic. Is that a separate bug or are twig functions in the Views UI limited to conditional logic?

It really seems there should be options in the UI to control decimal precision when using aggregation. Any updated ideas on how to achieve this?

#16 is good enough

Hi,

Tried #16 but its not working, the value returned as 0. Since the views uses the order total value (Sum and Average). Any update on this?

Hey all, I created a patch for this.

Can everyone test it and let me know if you find any side-effects. With this patch, you don't need to put anything in your template file or implement any hooks. Aggregated fields will have the same settings that non-aggregated decimal fields have, just like how it works in Drupal 7 right now.

It also fixes the bug of the 'Group column' and 'Group column (additional)' sections missing from a field's Aggregation settings

I overlooked something with patch #33. The 'thousand marker' settings was being duplicated. Fixed with this patch.

Thanks for fixing the whitespace issue @ranjith_kumar_k_u but there's actually a problem with the patch, which I only found out after I saved my view. I'll see if I can find a different way to fix this.

Edit:
Actually I think the patch works. I've been testing on two different sites, one was a vanilla install of drupal 9(using 9.5.x-dev) and the other one, a real site, with some custom modules. I found out that it was one of the custom modules that had caused the issue. It seems to be working fine with the vanilla drupal 9 site. I would love to get others' feedback though.

Ignore my previous patches. This problem seems to have originated from this commit: lets use annotated handlers in even more places

See attached image. In get_aggregation_info(), somebody pasted the field handler where it should've fallen through to the original handler. It seems like a copy/paste error.

This patch corrects that error, removing the field handler from sum, avg, min, max, and stddev_pop

#2735997-38: Decimal separator and decimals settings ignored when aggregating decimal fields While testing with @ramil g we thought through the possible regressions and this may need a CR for those that have implemented #2735997-23: Decimal separator and decimals settings ignored when aggregating decimal fields, but the twig template workaround should continue to work.

This also fixes a bug that we found that when you choose aggregation, the "Aggregation settings" lose the EntityField additional fields and yield a PHP 8.1 Warning (though notice in PHP 7) because it expects the "Group column" and " Group columns (additional)" there but they hide after any other option than "Group results together" is chosen.

Lovely to see older bugs getting fixed!

This issue summary is out of date and does not document the proposed change here. Adding tag. I've added some steps to reproduce because I had to poke around and figure out how to create the problem.

In #39 @joelpittet explains the testing that was done but this is a UI issue so before and after screen shots should be added to the issue summary.

Since no tests are breaking with the change should one be added to prevent future problems?

@quietone, thanks for the review, I've added the proposed change and yes probably could use a regression test.

I can apply the patch successfully and add before and after screenshots. Please review the screenshots.

@asad_ahmed Can you let us know why there is a comma separator in your screenshot?

Created patch for updated version 10.1.x

Resolve #47

Thanks for sharing a pragmatic Twig solution in #16 @Ben Greenberg. Drupal 10 is now on Twig 3, so the URL is https://twig.symfony.com/doc/3.x/filters/number_format.html, but the syntax is the same.