Setting required on radios marks all options required

Patch applies clean, Screen shots attached.

I am very pretty sure this needs to be fixed in D8 first. And there it can also be tested.

Just wondering, is this the fix for D8 ? https://www.drupal.org/node/1239930#comment-10371121

It looks different to me, can someone verify if this exists in D8 or not?

@fabianx

It looks different to me, can someone verify if this exists in D8 or not?

I confirmed that this is still an issue on 8.1.8

I added three fields to basic page content type:

• field_radio_state_test
• field_state_radio_children
• field_radio_state_children_text

Here is my form_alter hook:

function radio_state_form_node_page_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $form_state, $form_id) {
  // kint($form);

  $state_test = array(
    'required' => array(
      ':input[name="field_radio_state_test[value]"]' => array('checked' => TRUE)
    )
  );

  $form['field_state_radio_children']['widget']['#states'] = $state_test;
  $form['field_radio_state_children_text']['widget'][0]['value']['#states'] = $state_test;
  // kint($form['field_radio_state']['widget']['value']['#title']);
}

Thanks for checking, we need to fix this in D8 first and it needs some tests.

I was looking at the previous patch which only updates states.js. The best I can tell, it adds the styles ( red asterisk )...

In my above example I compared radio with text field. For radio fields, I found the following differences, e.target was a fieldset and the e.target.id includes '--wrapper'. For text fields, the e.target is the input and and the id matches the input. One more thing of note, the e.target.id is used to populate the label variable and in turn the find function. This will not return any results for radio fields. I quickly reviewed that this is working for checkboxes (checkboxes become required), the only difference I could determine off the bat was that checkboxes were in a div and not a fieldset.

Other than the js changes, is there any other work that needs to be completed for this? Possibly the new form fields added to validation? I am still new to Drupal but would love to help get this change in. If you could let me know the ETA on any patches and how I could assist, that would be appreciated.

Alright, my patch isn't going to win any awards but it does what I need it to do and hopefully shines some light on some of the issues.

Edit: add an image

The patch did not work for me in Drupal 8.2.x. I could not immediately 'grok' the patch to know why it did not work.

Below is the temporary CSS work-around that I am using in Webform 8.x-5.x

.form-checkboxes .form-required:after,
.form-radios .form-required:after {
  display: none;
}

The patch has been re-rolled for Drupal 8.5.x version.

@arunkumark - Your patch is missing the changes to the ES6 files. See this change record for more information.

- This patch fixes the coding standards errors present in #22
- Includes the changes ported to the .es6.js file.

Rerolled #24 because patch is not applied on D 8.4.3, do not commit this to 8.5.x

@nabiyllin Have a look at https://www.drupal.org/core/backport-policy. This change could get committed to 8.5.x and then possibly cherry-picked backwards.

- This is just a reupload of #24.

@drpal it's after patch merging, but I need in this patch now on project which work on 8.4.
I'm sure I'm not the only one who need this.

Only tests left here

Probably because of https://www.drupal.org/node/2986680

re-rolled

tagging for badcamp 2018

Meanwhile attaching patch for current core version with update for latest fix in states.es6.js and states.js files.

Tagging for DrupalNorth 2019

Tagging for DrupalCamp Colorado 2019 (Sunday August 4)

I use a slightly modified version of #38 for core 8.7.3 with webform 5.0-beta12.
Instead of setting the required classes onto the legend element I have to set the required classes onto the legend .fieldset-legend span element.

#2951317: Radios element missing "required" attribute is a related issue and is the CSS work-around from#17.

Tagging for SFDUG Global contrib weekend event (Thursday Jan 23)

Re-rolled for 9.1.x

The patch mentioned in #47 doesn't seem to work for me. I created two fields namely test and test condition. I added code to make test condition required when test has value = 'one' using form alter. What I observe before applying the patch is the div wrapper of the test condition radio button gets an attribute of required when the value of test = 'one' and the same is happening after I apply the patch.
Here is the screenshot which will make it more clear, what I did :

You can clearly see the required attribute on div which is completely useless. It should have been on one of the input fields of radio button.

Here, I have created a patch to fix the issue faced in #48. This patch will add the required attribute on the input tag instead of the div tag. How ever the tags like texarea are not handled. For them to be required we have add a custom validation on form submit as implemented in body field when you make it required.

After applying patch #50, it works for me.

Check the below screenshot, it is working as expected.

Alter hook look like below

$form['field_conditional']['#states']['required'] = [
    ':input[name=field_test]' => ['value' => 'one'],
  ];

Looks good to me for RTBC.

Thank guys!
Patch #42 worked for my.
Drupal 8.8.5.

Patch #50 not apply

https://www.drupal.org/files/issues/2020-05-26/2731991-50.patch (issue:#2731991 (Setting required on radios marks all options required))
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2020-05-26/2731991-50.patch

I thought I would test this but the Issue Summary does not include steps to reproduce. :-( I went ahead and added select list fields to the article content type on a fresh install of 9.2.x and using that I was not able to reproduce the problem.

The issue summary only describes the problem. tagging for issue summary update. For help with that there are Issue Summary Template examples available.

Patch #42 works for me in Drupal 8.9.13

Patch #50 works for me in Drupal 9.2.x

Re-roll patch created for 9.3.x.

Fixed "Custom command fail" issue. Please have a look.

Please ignore my previous(#62) patch, Fixed custom command fail issue.

Moving to PNMI as the summary needs an update. I tried replicating locally but was not able to. The required seems to just go to the label which is desired.

Definitely does not occur now, in Claro or Seven:

Re-rolling to 9.5.7 version

I would not recommend using this patch. The changes to core/misc/states.js are breaking form states on textfields and textareas, you cannot make those fields required anymore. Took me way too long to figure that out.