Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
While reading the base class description for ArgumentPluginBase
I was distracted by the crazy paving indentation. It got in the way of my understanding of what is going on, I don't want this for the next reader.
This is a highly focused issue to fix spacing ...
So is hopefully a quick to review issue.
ArgumentPluginBase is over 1000 lines long so a single issue to fix all the cs issues would be too much.
Comment | File | Size | Author |
---|---|---|---|
#11 | interdiff-2724297-9-11.txt | 1.12 KB | er.pushpinderrana |
#11 | fixing_indentation-2724297-11.patch | 2.08 KB | er.pushpinderrana |
#9 | interdiff-2724297-3-9.txt | 1.57 KB | er.pushpinderrana |
#9 | fixing_indentation-2724297-9.patch | 2 KB | er.pushpinderrana |
#3 | fixing_indentation-2724297-3.patch | 1.93 KB | Sonal.Sangale |
Comments
Comment #2
Sonal.Sangale CreditAttribution: Sonal.Sangale at Blisstering Solutions commentedComment #3
Sonal.Sangale CreditAttribution: Sonal.Sangale at Blisstering Solutions commentedFixed the indentation issue.
Comment #5
markdorisonComment #7
martin107 CreditAttribution: martin107 commentedAn issue for the random test fails exits.
#2724871: Random failure in \Drupal\migrate_drupal_ui\Tests\d7\MigrateUpgrade7Test
Comment #8
jhodgdonThanks! Better than the original, but still needs a bit of work:
Besides fixing the indentation, these lines should be rewrapped to as close to 80 characters as possible, without going over.
This line has an extra space at the end.
extra space at end.
Comment #9
er.pushpinderrana CreditAttribution: er.pushpinderrana as a volunteer and at Publicis Sapient for Publicis Sapient commentedIncorporated above suggested changes.
Comment #10
jhodgdonMuch better, thanks!
Still one wrapping problem:
These two lines should still be wrapped together.
Comment #11
er.pushpinderrana CreditAttribution: er.pushpinderrana as a volunteer and at Publicis Sapient for Publicis Sapient commentedThank you! Please review again.
Comment #12
jhodgdonThanks, this latest patch fixes the problem in the issue summary.
Comment #14
jhodgdonUnrelated fail.
Comment #15
xjmThank you for your work on cleaning up Drupal core's code style!
In order to fix core coding standards in a maintainable way, all our coding standards issues should be done on a per-rule basis across all of core, rather than fixing standards in individual modules or files. We should also separate fixes where we need to write new documentation from fixes where we need to correct existing standards. This all should be done as part of #2571965: [meta] Fix PHP coding standards in core. A good place to start is the child issues of #2572645: [Meta] Fix 'Drupal.Commenting.FunctionComment' coding standard.
For this issue, I did not find an existing rule; if there is not one then we will start by creating it in the Coder project.
For background information on why we usually will not commit coding standards fixes that aren't scoped in that way, see the core issue scope guidelines, especially the note about coding standards cleanups. That document also includes numerous suggestions for scoping issues including documentation coding standards cleanups.
Contributing to the overall plan above will help ensure that your fixes for core's coding standards remain in core the long term.