comma separated lists (css inline un-ordered lists) format without proper punctuation.

example:

CommentFileSizeAuthor
#23 2722457-nr-bot.txt1.72 KBneeds-review-queue-bot
#18 Screenshot from 2021-01-30 12-35-00.png66.77 KBanacolautti
#8 simplyTest_me--batch_error.png102.85 KBSKAUGHT
#5 2722457-follow_up--other-use-example.png35.87 KBSKAUGHT
#2 2722457-comment1__patch-applied.png14.78 KBSKAUGHT
#2 2722457-1--comma-list-item-list-element-humanizes-poorl.patch4.78 KBSKAUGHT
comma-list_poor-humanization.png6.34 KBSKAUGHT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SKAUGHT created an issue. See original summary.

SKAUGHT’s picture

SKAUGHT
Primary language English
CreditAttribution: SKAUGHT as a volunteer commented
FileSize
2722457-1--comma-list-item-list-element-humanizes-poorl.patch4.78 KB
2722457-comment1__patch-applied.png14.78 KB


patch includes '&' symbol for the following languages:

tamil ta  மற்றும்
spanish es  y
sinhala si  සහ
sindhi sd  ۽
persian fa  و
nepali ne  र
marathi mr  आणि
latvian lv  ແລະ
kyrgyz ky  및
khmer km  និង
hindi hi  और
gujarati gu  અને
georgian ka  და
estonian et  ja
catalan ca  i
arabic ar  و

Source is Google translate (best source i could find). Accordingly, These are the only languages that do not use '&'

SKAUGHT’s picture

SKAUGHT
Primary language English
CreditAttribution: SKAUGHT as a volunteer commented
Status: Active » Needs review
SKAUGHT’s picture

SKAUGHT
Primary language English
CreditAttribution: SKAUGHT as a volunteer commented
Related issues: +#2242631: Plural lists should use HTML lists rather than simply implode(', ', $var), +#2455933: Error highlighting and reporting problems for the current password on the user profile form
SKAUGHT’s picture

SKAUGHT
Primary language English
CreditAttribution: SKAUGHT as a volunteer commented
FileSize
2722457-follow_up--other-use-example.png35.87 KB

adding other example. as this element is used in a variety of spots. (ie: /admin/modules )

can be found by searching for ['list_style' => 'comma-list']

Status: Needs review » Needs work

The last submitted patch, 2: 2722457-1--comma-list-item-list-element-humanizes-poorl.patch, failed testing.

SKAUGHT’s picture

SKAUGHT
Primary language English
CreditAttribution: SKAUGHT as a volunteer commented 
Migrate_drupal_ui.Drupal\migrate_drupal_ui\Tests\d7\MigrateUpgrade7Test
✓		- setUp
✗	
testMigrateUpgrade
fail: [Other] Line 139 of core/modules/migrate_drupal_ui/src/Tests/MigrateUpgradeTestBase.php:
"Congratulations, you upgraded Drupal!" found

i have no idea why this test would fail against a CSS change. especially, considering it's looking for a drupal_set_message that isn't using a comma-list at all. i have to assume there something wrong with this test on it's own.

  • test doesn't seem to include a dbase the import would be used with.
  • or ,could this be a file move error in the test env?
SKAUGHT’s picture

SKAUGHT
Primary language English
CreditAttribution: SKAUGHT as a volunteer commented
FileSize
simplyTest_me--batch_error.png102.85 KB

simplytest.me test result on individual MigrateUpgrade7Test run on 8.1.1 (current release)

also:
Fatal error: Trait 'Drupal\Tests\SessionTestTrait' not found in /home/d0s72/www/core/modules/simpletest/src/TestBase.php on line 28

SKAUGHT’s picture

SKAUGHT
Primary language English
CreditAttribution: SKAUGHT as a volunteer commented
Status: Needs work » Needs review

passes manually run test. ???

SKAUGHT’s picture

SKAUGHT
Primary language English
CreditAttribution: SKAUGHT as a volunteer commented
Related issues: +#2505931: Remove SafeMarkup::set in ViewListBuilder

just linking
seems to be original issue for comma_list creation

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

anacolautti’s picture

anacolautti CreditAttribution: anacolautti at easytechgreen commented
FileSize
Screenshot from 2021-01-30 12-35-00.png66.77 KB

I tried reproducing this issue in order to test the fix, but I can't. I don't understand how to trigger the error presented in the first screenshot.

In a Drupal 8.9-dev site (from 2021-Jan-20), I tried to enter incorrect values to the user edit form, but got three separated error messages that don't resemble the one in the screenshot:
Error messaged appear in separate lines.

Could someone explain how to reproduce this issue a bit more? Thanks!

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
2722457-nr-bot.txt1.72 KB

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.