Follow-up to #2568171: Upgrade to Twig 1.22 and implement our own cache class

Problem/Motivation

Made major due to the Fixes for parsing for PHP7
https://github.com/twigphp/Twig/commit/24d9266d0f1c2b4426ad8f931be30718c...

+* 1.24.0 (2016-01-25)
+
+ * adding support for the ?? operator
+ * fixed the defined test when used on a constant, a map, or a sequence
+ * undeprecated _self (should only be used to get the template name, not the template instance)
+ * fixed parsing on PHP7
+
+* 1.23.3 (2016-01-11)
+
+ * fixed typo
+
+* 1.23.2 (2015-01-11)
+
+ * added versions in deprecated messages
+ * made file cache tolerant for trailing (back)slashes on directory configuration
+ * deprecated unused Twig_Node_Expression_ExtensionReference class
+
+* 1.23.1 (2015-11-05)

Proposed resolution

Upgrade to 1.24

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#2 upgrade_to_twig_1_24-2721351-2.patch1.55 KBjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
FileSize
upgrade_to_twig_1_24-2721351-2.patch1.55 KB
star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr at Northern Commerce commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +8.2.0 release notes

Committed 45d0a03 and pushed to 8.2.x. Thanks!

  • alexpott committed 45d0a03 on 8.2.x 
    Issue #2721351 by joelpittet: Upgrade to Twig 1.24
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

Made major due to the Fixes for parsing for PHP7

Shouldn't this qualify this issue for 8.1.x?

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr at Northern Commerce commented

I looked at the commit linked in the issue summary and it seems like an edge case to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

@jibran they've bumped their minor version so I think we should only bump it in a minor too

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.