Problem/Motivation

Follow-up to #2714815: Fix 'Drupal.Semantics.ConstantName.ConstantStart' coding standard

Child of #2571965: [meta] Fix PHP coding standards in core

Drupal.Semantics.ConstantName.ConstantStart coding standard error tells us that constants defined in a module should have that module's name as the first word.

The only violation of this is in search module, which has PREG_CLASS_NUMBERS, PREG_CLASS_PUNCTUATION, and PREG_CLASS_CJK.

We can't remove these constants until the Drupal 9.0.x, so they are deprecated in #2714815: Fix 'Drupal.Semantics.ConstantName.ConstantStart' coding standard.

Proposed resolution

Wait for Drupal 9.0.x development time.

Change or remove these constants as appropriate.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Mile23 created an issue. See original summary.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Active » Postponed

Immediately postponed on the Drupal 9 development cycle.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Title: Update search module's PREG_CLASS_NUMBERS, PREG_CLASS_PUNCTUATION to CS » Update search module's PREG_CLASS_NUMBERS, PREG_CLASS_PUNCTUATION, PREG_CLASS_CJK to CS
Issue summary: View changes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Postponed » Closed (duplicate)

I think we don't need this follow-up, if we follow #2714815-12: Fix 'Drupal.Semantics.ConstantName.ConstantStart' coding standard (which would be a more normal way to handle deprecations).

Version: 9.x-dev » 9.0.x-dev

The 9.0.x branch will open for development soon, and the placeholder 9.x branch should no longer be used. Only issues that require a new major version should be filed against 9.0.x (for example, removing deprecated code or updating dependency major versions). New developments and disruptive changes that are allowed in a minor version should be filed against 8.9.x, and significant new features will be moved to 9.1.x at committer discretion. For more information see the Allowed changes during the Drupal 8 and 9 release cycles and the Drupal 9.0.0 release plan.