Add plural labels to Entity Types in Image module [#2702687]

Follow-up to #2702669: Add plural labels to Entity Types in Aggregator module

Problem/Motivation

As it has been introduced in #1850080: Entity type labels lack plurality, cannot generate UI text based on label if plural is needed now we have a way to specify plural label for any entity type. Let's do it for Image module.

Proposed resolution

Add plural labels to all entity types defined by Image module. More information can be found in the change record: https://www.drupal.org/node/2689949

Remaining tasks

Write the patch.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

Comment	File	Size	Author
#6	2702687-6.patch	676 bytes	vdanielpop
#6	8.1.x: PHP 5.5 & MySQL 5.5 18,530 pass
#4	2702687-4.patch	695 bytes	vdanielpop
#4	8.1.x: PHP 5.5 & MySQL 5.5 18,529 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

8 April 2016 at 13:35

vdanielpop created an issue. See original summary.

Comment #2

vdanielpop CreditAttribution: vdanielpop commented 8 April 2016 at 13:36

Parent issue:

#2702669: Add plural labels to Entity Types in Aggregator module

» #1850080: Entity type labels lack plurality, cannot generate UI text based on label if plural is needed

Comment #3

vdanielpop CreditAttribution: vdanielpop commented 8 April 2016 at 13:48

Issue tags:

+DCTransylvania

Comment #4

vdanielpop CreditAttribution: vdanielpop commented 8 April 2016 at 14:22

Assigned:	vdanielpop	» Unassigned
Status:	Active	» Needs review

File	Size
2702687-4.patch	695 bytes
8.1.x: PHP 5.5 & MySQL 5.5 18,529 pass

Comment #5

bojanz CreditAttribution: bojanz at Centarro commented 8 April 2016 at 15:11

Status:

Needs review

» Needs work

Thanks!

+ *   label_singular = @Translation("image style item"),
+ *   label_plural = @Translation("image style items"),
+ *   label_count = @PluralTranslation(
+ *     singular = "@count image style item",
+ *     plural = "@count image style items"
+ *   ),

Why did we add the word "item"? I don't think we need it.
What we do need is a trailing comma on the plural line.

Comment #6

vdanielpop CreditAttribution: vdanielpop at PitechPlus commented 8 April 2016 at 21:50

Status:

Needs work

» Needs review

File	Size
2702687-6.patch	676 bytes
8.1.x: PHP 5.5 & MySQL 5.5 18,530 pass

You're right, I wasn't paying enough attention.

Comment #7

bojanz CreditAttribution: bojanz at Centarro commented 8 April 2016 at 22:14

Status:

Needs review

» Reviewed & tested by the community

Looks good, thanks.

Comment #8

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 11 April 2016 at 20:21

Status:	Reviewed & tested by the community	» Closed (duplicate)
Related issues:		+#2702683: Add plural labels to entity types

Hi DCTransilvania contributors and others -- can you please comment on #2702683: Add plural labels to entity types to receive credit? Splitting up patches per-module is not ideal in most cases, especially for a single, simple change, so let's use a combined patch. Thank you!