Allow exposed form for non-ajax block displays

I have checked this issue in 8.2.x-dev.Its working fine.

I changed it from bug report to feature request because it works when ajax is turned on for the view.

Needs a reroll for 8.3.x?

Here is a patch for 8.3.x

The patch applies and works against 8.4.x

Patch still applies to 8.5.4 and works very well, thanks!

We need tests to make sure that this works, and keeps working :)

Will this be merged into the next core update?

Patch still applies on 8.6.10 and works, thanks!

The only problem I see with this patch is that once enabled, effectively block output need to be cached per page and query parameter.
I guess that's an okayish price to pay, if you want to have this functionality, but maybe somehow warning the user could be nice.

On top of that I did some historic investigation. There is this comment from @merlinofchaos: https://www.drupal.org/project/views/issues/1115782#comment-4582214 , but well, I'm not sure this still applies for today.

I agree with @borisson_, we really need a test for this functionality, which could for example test the cacheability metadata.

Is this a duplicate issue Allow exposed-form-in-block for block displays?

For my use case I have a view with faceted search using Search API and Facets. I need to expose the Fulltext search as block which was possible because of the patch 2692297-8.patch (thank you!) so that I can setup facets with it.

I have two displays in my view, one with the search list (block) and next with details (page with a url) using a contextual filter. After applying the patch, the search is redirected to the url of page from details display. This is because the exposed search form has action url of the details page. With some investigation, ViewsExposedForm.php plugin in the Views module has

$form['#action'] = $view->hasUrl() ? $view->getUrl()->toString() : Url::fromRoute('<current>')->toString(); on line 116.

And $view->hasUrl() returns true if any display of the view has a url, which in my case is not correct. The form should post back to the page itself. To fix this:
1. Workaround, rather than creating one view with two displays, create two separate views.
2. In ViewsExposedForm.php pass current display id to $view->hasUrl() since hasUrl accepts $display_id as argument hasUrl($args = NULL, $display_id = NULL)?

Please let me know if this makes sense, I am fairly new to Drupal.

#8 works for me on 8.6.17.

Quick reroll of patch #8 for 8.9.* since it didn't apply anymore

My workaround for a specific views block:

/**
 * Implements hook_form_alter().
 */
function HOOK_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $form_state, $form_id) {
  switch ($form_id) {
    case 'views_exposed_form':
      if ($form['#id'] === 'views-exposed-form-example-block-1') {
        $nid_view = '7';
        $url = Url::fromRoute('entity.node.canonical', ['node' => $nid_view])->toString();

        // Because reload is not working correctly.
        $form['#action'] = $url;
        $form['#attached']['library'][] = 'example/example';
      }
      break;
  }
}

(function ($, Drupal, drupalSettings) {
  Drupal.behaviors.exampleTest = {
    attach: function (context, settings) {

      let $actions = $(".block-views-example-block-1 div[data-drupal-selector='edit-actions'] input.form-submit");
      if ($actions.length) {
        // Prevent Ajax from submit handler.
        $actions.unbind();
      }

      if (window.location.href.indexOf("field_example_filter") > -1) {
        let $block_view_block_1 = $('.block-views-example-block-1');
        if($block_view_block_1.length ){
          $("html, body").animate({ scrollTop: $block_view_block_1.offset().top }, "slow");
        }
      }
    }
  };
})(jQuery, Drupal, drupalSettings);

This issue has a patch. Changing its states to needs review.

Patch still requires tests.

The most recent patch does not apply in 9.3. The method these patches have been removing now looks like this:

  public function usesExposed() {
    if (!isset($this->has_exposed)) {
      foreach ($this->handlers as $type => $value) {
        foreach ($this->view->$type as $handler) {
          if ($handler->canExpose() && $handler->isExposed()) {
            // One is all we need; if we find it, return TRUE.
            $this->has_exposed = TRUE;
            return TRUE;
          }
        }
      }
      $pager = $this->getPlugin('pager');
      if (isset($pager) && $pager->usesExposed()) {
        $this->has_exposed = TRUE;
        return TRUE;
      }
      $this->has_exposed = FALSE;
    }

    return $this->has_exposed;
  }

Can anyone say whether this change happens to resolve this issue? I'll reroll the patch anyways.

Actually this issue is fixed for me in 9.3 without any patch! Assuming this fix was introduced in one of the related issues.

Yep its now returning TRUE by default: https://git.drupalcode.org/project/drupal/-/blob/9.3.x/core/modules/view...
As a result of https://www.drupal.org/project/drupal/issues/2681947

Happy to mark this as closed!