Problem/Motivation

Migrate maintainers is out of date.

Proposed resolution

Update the list and have one entry for the migration subsystem.

Remaining tasks

Make a patch.
Agree on it.
Commit it.

Original Issue Summary

Problem/Motivation

Proposed resolution

  • Add Drupal Upgrade UI MAINTAINERS.txt entry.
  • Add migrate_drupal_ui.module component.

Remaining tasks

TBD

CommentFileSizeAuthor
#18 interdiff-2680097-14-18.txt501 bytesmaxocub
#18 2680097-18.patch880 bytesmaxocub
#14 2680097-14.patch757 bytesquietone
#4 Added-Drupal-Upgrade-UI-entry-to-MAINTAINERS.txt-2680097-4.patch1.05 KBvg3095
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Related issues: +#2679739: [Policy, no patch] Make the migrate_drupal_ui module part of the migrate_drupal module

Added related issue #2679739: [Policy, no patch] Make the migrate_drupal_ui module part of the migrate_drupal module

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

vg3095’s picture

vg3095 CreditAttribution: vg3095 commented
FileSize
Added-Drupal-Upgrade-UI-entry-to-MAINTAINERS.txt-2680097-4.patch1.05 KB

I added entry of Drupal Upgrade UI in maintainers.txt

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Status: Active » Postponed

postponing this one b/c there is one issue #2679739: [Policy, no patch] Make the migrate_drupal_ui module part of the migrate_drupal module to make the migrate_drupal_ui as a part of migrate_drupal

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Component: base system » migration system
Related issues: +#2660144: [Plan] Update core components

Thanks @naveenvalecha for thinking of this!

I am definitely not going to be a subsystem maintainer for this module. :) I'd actually recommend we combine all Migrate entries into a single subsystem. So what is in HEAD:

Migrate module
- Ben Dougherty 'benjy' https://www.drupal.org/u/benjy
- Michael Anello 'ultimike' https://www.drupal.org/u/ultimike
- Mike Ryan 'mikeryan' https://www.drupal.org/u/mikeryan

Migrate (Drupal) module
- Ben Dougherty 'benjy' https://www.drupal.org/u/benjy
- Michael Anello 'ultimike' https://www.drupal.org/u/ultimike
- Mike Ryan 'mikeryan' https://www.drupal.org/u/mikeryan

...would simply just be combined into one subsystem as it is with the issue component.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Postponed » Needs work

Un-postponing. Sounds like we can at least decide on whether to create a sub-system in maintainers.txt without the dependency being resolved.

Once the decision is reach, the creating of the entry in maintainters.txt is novice, so leaving that tag on here.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

This is still postponed actually. Thanks @heddn for checking back in on it.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs work » Postponed

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Postponed » Needs review

#2679739: [Policy, no patch] Make the migrate_drupal_ui module part of the migrate_drupal module has been closed. So I think this is no longer postponed.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Title: Add Drupal Upgrade UI to MAINTAINERS.txt » Update Migrate entries in MAINTAINERS.txt
Issue summary: View changes
FileSize
2680097-14.patch757 bytes

Yes, let's combine all the Migrate entries into one for the migration subsystem as suggested by xjm in #6.

The attached patch does that, removing inactive maintainers. I'd like to add new maintainers but that discussion was at the end of the sprint and I am not 100% sure I heard what I think I heard!

Updated the IS and title.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Needs work

Let's add maxocub to maintainers and remove mike ryan and benjy. +1 on combining all three modules into a migrate subsystem entry.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

Here's the link to the requirements for a subsystem maintainer: https://www.drupal.org/contribute/core/maintainers#subsystem. I think @maxocub well fits the description, and has for a while.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
Status: Needs work » Needs review

I would be happy to be a migrate subsystem maintainer and I accept the responsibilities associated with this title.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
Status: Needs review » Needs work
FileSize
2680097-18.patch880 bytes
interdiff-2680097-14-18.txt501 bytes

Oups, great start, I forgot the patch!

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
Status: Needs work » Needs review

Damn it, back to NR, I blame this on the Drupal flu!

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Issue tags: -Novice

Waiting on +1 from other maintainers, but this looks good so far.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented

Absolutely +1

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Yes.

masipila’s picture

masipila CreditAttribution: masipila as a volunteer commented

Congrats @maxocub! You've been so active in all the issues that I've created in the migrate issue queue lately that I actually thought you already were a maintainer! Hats off for your work and congrats once more!

Cheers,
Markus

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

I've also confirmed with Mike that he's ok with removing his name. We checked with benjy last time around and he was OK with us removing him at that time. So I think that covers all the bases.

  • Gábor Hojtsy committed 03c7c8a on 8.5.x 
    Issue #2680097 by maxocub, quietone, vg3095, heddn, xjm: Update Migrate...

  • Gábor Hojtsy committed 9f844ba on 8.4.x 
    Issue #2680097 by maxocub, quietone, vg3095, heddn, xjm: Update Migrate...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

I read all the things in https://www.drupal.org/contribute/core/maintainers on rules of updating maintainers and this seems to check of all the boxes in terms of signoffs so I should be able to commit it.

Huge thanks for your continued work on this very difficult and critical part of Drupal.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.