watchdog('file', t('%source has been renamed to %destination', array('%source' => $old_filename, '%destination' => $file->filename)));

According to the documentation the message should not be translated.

CommentFileSizeAuthor
#2 2677118-2.patch1.51 KBChi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Active » Needs review
FileSize
2677118-2.patch1.51 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2677118-2.patch, failed testing.

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs work » Needs review
poker10’s picture

poker10 CreditAttribution: poker10 at ActivIT s.r.o. commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Pending Drupal 7 commit

Thanks, this looks as a good fix!

I have quickly checked the whole D7 codebase and it seems like these three are the only usages of watchdog() with the t() function. RTBC.

  • mcdruid committed 4884d155 on 7.x 
    Issue #2677118 by Chi, poker10: Wrong usage of watchdog in system.api....
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

...these three are the only usages of watchdog() with the t() function.

Great; thanks for the patch and the review!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.