Since #1850164: Default state of toolbar should show menu tray in non-narrow viewports the toolbar always stays open. This is non-intuitive. If I close the toolbar, I do not expect it to be open again on the next page refresh.

Both this issue and the aforementioned one can be accomplished at the same time. The toolbar can default to open, and still remember its open/closed state.

CommentFileSizeAuthor
#21 drupal-toolbar_remember_open_state-2667396-21.patch1.16 KBckaotik
#3 2667396-3.patch2.45 KBtwistor
#2 2667396-2.patch1.48 KBtwistor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

twistor created an issue. See original summary.

twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented
Title: Make the toolbar remember its open/closed state. » Make the toolbar remember its open/closed state when in the horizontal position.
Status: Active » Needs review
FileSize
2667396-2.patch1.48 KB
twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented
FileSize
2667396-3.patch2.45 KB

This one should actually work.

I don't really like using the tri-state variable, (null, false, string) but it works for now. It can be polished up if agreement is reached.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mathieuhelie’s picture

mathieuhelie CreditAttribution: mathieuhelie at Floe design + technologies commented
Status: Needs review » Reviewed & tested by the community

Patch tests correctly on my end. I see what you mean about using a 'false' state to represent the closed toolbar, it's not obvious what the behavior of the code is, or why we are saving false instead of unsetting the localstorage state. We could use a string literal such as "active-tab-none" and modify the view's render logic to check for that literal.

I will try to rework the patch along those lines, but I approve 2667396-3.patch.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer and at Northern Commerce commented
Issue tags: +JavaScript
esod’s picture

esod CreditAttribution: esod at Memorial Sloan Kettering Cancer Center commented

The patch works for me. Adding testing for 8.2.x and 8.1.x

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer and at Northern Commerce commented

Should we consider adding another property to the model to store a boolean rather than complicating activeTab?

droplet’s picture

droplet CreditAttribution: droplet commented

Oh. Seems like this issue would make my hard working doesn't work anymore and we can't fix the issue forever:
#2542050: Toolbar implementation creates super annoying re-rendering.

Unless we do this:
#2696023: Save Users' Toolbar State config to serverside

I think we should consider above 2 issues before this commit. It creates more noise and unable to revert in the future.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer commented
Status: Reviewed & tested by the community » Needs review
mathieuhelie’s picture

mathieuhelie CreditAttribution: mathieuhelie at Floe design + technologies commented

I agree with #8, whether or not the bottom tray is open is a different state than what the active tab is.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

thamas’s picture

thamas
Primary language Hungarian
Location Hungary
CreditAttribution: thamas at Integral Vision Ltd commented
Related issues: +#2542050: Toolbar implementation creates super annoying re-rendering., +#2696023: Save Users' Toolbar State config to serverside
thamas’s picture

thamas
Primary language Hungarian
Location Hungary
CreditAttribution: thamas as a volunteer commented
Status: Needs review » Needs work

This issue could resolve a big (UX) pain of me about Drupal 8!

While the latest patch just works for me with the latest Drupal version of this time (8.2.3) I just mark this as Needs Work because of the comments in #9 and #8.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

ckaotik’s picture

ckaotik
Primary language German
Location Berlin
CreditAttribution: ckaotik at werk21 commented
Status: Needs work » Needs review
Issue tags: -JavaScript +JavaScript
FileSize
drupal-toolbar_remember_open_state-2667396-21.patch1.16 KB

I've ported the patch from #3 to D8.9. Instead of "false" I set the empty string to illustrate "the user's choice is: none", so we don't even need to alter the variable documentation. This fixed my issue on mobile, where the vertical toolbar was always open but invisible on page load, further reducing the already limited horizontal space.

The changes probably still need to be properly built using yarn, as of Drupal core now using ES6 for JavaScript development. Setting to NR for the testbot, to be reverted to NW for #8 and #9.

ckaotik’s picture

ckaotik
Primary language German
Location Berlin
CreditAttribution: ckaotik at werk21 commented
Status: Needs review » Needs work

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.