Follow-up to #1475510: Remove external dependencies from the core repo and let Composer manage the dependencies instead
Problem/Motivation
Now that vendor folder is composer managed (#1475510: Remove external dependencies from the core repo and let Composer manage the dependencies instead), let's update example.gitignore to reflect this change.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#12 | 2662220-11.patch | 602 bytes | vijaycs85 |
#10 | ignore-vendor-2662220-10.patch | 519 bytes | igasi |
#10 | interdiff-2662220-8-10.txt | 505 bytes | igasi |
#8 | ignore-vendor-2662220-8.patch | 578 bytes | igasi |
#5 | ignore-vendor-2662220-5.patch | 419 bytes | igasi |
Comments
Comment #2
igasi CreditAttribution: igasi commentedI hope with this is enough :)
Comment #3
igasi CreditAttribution: igasi commentedComment #4
vijaycs85comment as well
Comment #5
igasi CreditAttribution: igasi as a volunteer commentedIgnoring core folder too
Comment #6
igasi CreditAttribution: igasi as a volunteer commentedComment #7
gnugetYou need to delete the comment as well no just the #vendor, #core lines.
Also, not sure if we should uncomment the core line yet.
And thinking on this we don't want to delete the comment just change what it says.
Maybe with something like:
Comment #8
igasi CreditAttribution: igasi as a volunteer commentedThanks for your comments
Edit the comment to only refer to the core, leaving commented. Since we know yet whether to uncomment.
And create a new comment to ignore the vendor directory.
Comment #9
gnugetAll the inline comments must finish with a dot. check:
https://www.drupal.org/coding-standards/docs#inline
Also not sure about if we should preserve the comment just with the "core" folder, let's wait for a second opinion.
And finally, every time to a new patch is uploaded we need to upload an interdiff, more info about that here:
https://www.drupal.org/documentation/git/interdiff
This is almost ready thanks!
Comment #10
igasi CreditAttribution: igasi as a volunteer commentedThanks a lot for your feedback gnuget.
Now I followed the standard for inline comments, removed the comment and core, thinking more about the comment #4 vijaycs85
I also created the interdiff
Comment #11
vijaycs85I don't believe core is managed by composer yet. We might need to keep 'core' part.
Comment #12
vijaycs85Comment #13
jhodgdonThis is awkward wording and/or ungrammatical. Should be something like "Ignore vendor, which contains..."
contains is also misspelled.
And... I am not sure this is right anyway. vendor still seems to be in the git repository as of right now.
Comment #14
jhodgdonYeah, the patch that removed /vendor stuff got reverted. This needs to be postponed.
Comment #20
tstoecklerThis was fixed in the parent directly.
Comment #21
chankongching CreditAttribution: chankongching commentedi have just encountered issue with vendor directory so i am updating this issue.
.gitnore shld use '/vendor' instead of 'vendor' only coz there is core/assets/vendor directory that contains a lot of js library