Follow-up to #1475510: Remove external dependencies from the core repo and let Composer manage the dependencies instead

Problem/Motivation

Now that vendor folder is composer managed (#1475510: Remove external dependencies from the core repo and let Composer manage the dependencies instead), let's update example.gitignore to reflect this change.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 2662220-11.patch602 bytesvijaycs85
#10 ignore-vendor-2662220-10.patch519 bytesigasi
#10 interdiff-2662220-8-10.txt505 bytesigasi
#8 ignore-vendor-2662220-8.patch578 bytesigasi
#5 ignore-vendor-2662220-5.patch419 bytesigasi
#2 ignore-vendor-2662220-2.patch336 bytesigasi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85 created an issue. See original summary.

igasi’s picture

igasi CreditAttribution: igasi commented
FileSize
ignore-vendor-2662220-2.patch336 bytes

I hope with this is enough :)

igasi’s picture

igasi CreditAttribution: igasi commented
Status: Active » Needs review
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 at Capgemini commented
Status: Needs review » Needs work 
+++ b/example.gitignore
@@ -9,7 +9,7 @@
 # Ignore core and vendor when managing dependencies with Composer.
 # core

comment as well

igasi’s picture

igasi CreditAttribution: igasi as a volunteer commented
FileSize
ignore-vendor-2662220-5.patch419 bytes

Ignoring core folder too

igasi’s picture

igasi CreditAttribution: igasi as a volunteer commented
Status: Needs work » Needs review
gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer commented
Status: Needs review » Needs work 
 # Ignore core and vendor when managing dependencies with Composer.
-# core
-# vendor

You need to delete the comment as well no just the #vendor, #core lines.

Also, not sure if we should uncomment the core line yet.

And thinking on this we don't want to delete the comment just change what it says.

Maybe with something like:

# Ignore vendor file.

igasi’s picture

igasi CreditAttribution: igasi as a volunteer commented
Status: Needs work » Needs review
FileSize
ignore-vendor-2662220-8.patch578 bytes

Thanks for your comments

Edit the comment to only refer to the core, leaving commented. Since we know yet whether to uncomment.

And create a new comment to ignore the vendor directory.

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer commented
Status: Needs review » Needs work 
+++ b/example.gitignore
@@ -7,9 +7,11 @@
-# vendor
+
+# Ignore vendor directory
+vendor

All the inline comments must finish with a dot. check:
https://www.drupal.org/coding-standards/docs#inline

Also not sure about if we should preserve the comment just with the "core" folder, let's wait for a second opinion.

And finally, every time to a new patch is uploaded we need to upload an interdiff, more info about that here:

https://www.drupal.org/documentation/git/interdiff

This is almost ready thanks!

igasi’s picture

igasi CreditAttribution: igasi as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-2662220-8-10.txt505 bytes
ignore-vendor-2662220-10.patch519 bytes

Thanks a lot for your feedback gnuget.

Now I followed the standard for inline comments, removed the comment and core, thinking more about the comment #4 vijaycs85

I also created the interdiff

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 at Capgemini commented

I don't believe core is managed by composer yet. We might need to keep 'core' part.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 at Capgemini commented
FileSize
2662220-11.patch602 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work 
+++ b/example.gitignore
@@ -7,9 +7,11 @@
+# Ignore vendor that contians external libraries.

This is awkward wording and/or ungrammatical. Should be something like "Ignore vendor, which contains..."

contains is also misspelled.

And... I am not sure this is right anyway. vendor still seems to be in the git repository as of right now.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs work » Postponed

Yeah, the patch that removed /vendor stuff got reverted. This needs to be postponed.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Status: Postponed » Closed (duplicate)

This was fixed in the parent directly.

chankongching’s picture

chankongching CreditAttribution: chankongching commented

i have just encountered issue with vendor directory so i am updating this issue.
.gitnore shld use '/vendor' instead of 'vendor' only coz there is core/assets/vendor directory that contains a lot of js library