API page: https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/functi...

In the documentation, this text "In order for strings to be localized, make them available in one of the ways supported by the Localization API. " contains a link to the localization API page here https://www.drupal.org/node/322729, but that page is for D6/7. This should probably link to https://www.drupal.org/developing/api/8/localization instead.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eojthebrave created an issue. See original summary.

eojthebrave’s picture

Status: Active » Needs review
FileSize
1.02 KB

And, here's a patch with the change.

jhodgdon’s picture

Status: Needs review » Needs work

Thanks! I think we would actually be better off linking to
https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Language!language...
which would look something like

@link i18n Localization API. @endlink
eojthebrave’s picture

Status: Needs work » Needs review
FileSize
973 bytes

Here's a new patch using "@link i18n Localization API. @endlink" instead, and re-warping the comment to 80 chars.

jhodgdon’s picture

Status: Needs review » Needs work

It looks like the @link ... @endlink would fit on the previous line?

I like the idea of warping comments. ;)

eojthebrave’s picture

Status: Needs work » Needs review
FileSize
1.04 KB

You, see, that comment was warped. But now it's properly wrapped. :)

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/includes/bootstrap.inc
@@ -258,11 +258,10 @@ function drupal_get_path($type, $name) {
+ * supported by the @link i18n Localization API. @endlink. When possible, use

I think there are too many fullstops. I think the one after API is not necessary.

jhodgdon’s picture

Yeah, I think we should take out the one after @endlink -- sorry I didn't notice the duplication.

imalabya’s picture

Added an updated patch with the above comment.

jhodgdon’s picture

This latest patch is missing a lot from the earlier patch. Looks like it's more like an interdiff? We need a full patch. Thanks!

imalabya’s picture

Hi @jhodgdon, sorry for the confusion. I was too quick. Have added the complete patch with the updates. Hope this is good.

imalabya’s picture

Status: Needs work » Needs review
jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

The last submitted patch, 10: 2651766-10-update_link.patch, failed testing.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 5b912b4 and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed 5b912b4 on
    Issue #2651766 by eojthebrave, malavya, jhodgdon, alexpott: Update link...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.