Reproduce:

Create a modal link within the body field of a node on a vanilla 8.0.1 standard profile installation.
<a class="use-ajax" data-dialog-type="modal" href="/node/2">Show me a modal</a>

View the node using Bartik

Expecting:

The node title displayed in the modal title area.

Actual:

The modal title displays encoded markup.

CommentFileSizeAuthor
#9 2637550-8.patch1.21 KBjoelpittet
#3 strip-tags-from-modal-title-2637550-3.patch981 bytesrattusrattus
#2 Screen+Shot+2015-12-18+at+11.03.49.png98.54 KBrattusrattus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ratface created an issue. See original summary.

rattusrattus’s picture

rattusrattus CreditAttribution: rattusrattus commented
FileSize
Screen+Shot+2015-12-18+at+11.03.49.png98.54 KB

Adding screenshot.

rattusrattus’s picture

rattusrattus CreditAttribution: rattusrattus commented
FileSize
strip-tags-from-modal-title-2637550-3.patch981 bytes

Patch to strip any markup from content tile before passing to OpenModalDialogCommand.

rattusrattus’s picture

rattusrattus CreditAttribution: rattusrattus commented
Status: Active » Needs review
rattusrattus’s picture

rattusrattus CreditAttribution: rattusrattus at CTI Digital commented
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Parent issue: » #2297711: Fix HTML escaping due to Twig autoescape

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
FileSize
2637550-8.patch1.21 KB

This likely needs some tests but I'm not sure. I think the patch is correct, I've seen some other modal related issues that are using PlainTextOutput::renderFromHtml, so I've swapped that out. Do you think that is ok @ratface? Also do you think you'd be up for writing an integration test for this?

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs review » Closed (duplicate)

This looks to be solved by #2207247: Dialog titles double escaped for views handlers and delete forms