Problem/Motivation
The issue/patch that removed the "logo" feature from _system_default_theme_features() is: #2005546-27: Use branding block in place of page template branding variables (site name, slogan, site logo).
There was an unforeseen consequence to removing the features from this function: you cannot change the logo if a theme does not explicitly specify this feature in their .info.yml file (which none of the core themes do, e.g. you can't change the logo for Bartik).
This issue is further compounded by the fact that if you create additional sub-themes, simply changing the "Global settings" logo (which is the current workaround) will not work in all instances.
Proposed resolution
- Add the "logo" feature back to _system_default_theme_features()
Remaining tasks
Create patch
User interface changes
- The "Logo" vertical tab on theme settings page will show up again and allow users to upload a custom logo for a specific theme.
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#4 | themes_that_do_not-2634252-4.patch | 819 bytes | markhalliwell |
Comments
Comment #2
markhalliwellComment #3
markhalliwellComment #4
markhalliwellComment #5
markhalliwellComment #6
star-szrThanks! If I'm not mistaken we could use your help and code in #2620176: Logo image settings form is broken, breaks per-theme overrides and can result in data loss :)
If I am mistaken definitely feel free to re-open.
Comment #7
markhalliwellConsidering that this issue already has a patch, and details exactly where/what caused the issue, I'd rather keep this one open.
Comment #8
DevElCuy CreditAttribution: DevElCuy at Dilygent commented@markcarver, please be considerate with core devs time. This ticket was marked duplicate for a good reason. You can propose your alternative solution in the other issue: #2620176: Logo image settings form is broken, breaks per-theme overrides and can result in data loss
Thanks!
Comment #9
markhalliwell@develCuy, I am a core dev (or rather was at one point). I don't know what your issue is with me, but please be respectful to all people, not just "core devs".
edit: p.s. it wasn't a "good reason", it was about feelings. Normally we close issues in favor of ones that have patches (not always by date), but whatever. I've uploaded the patch there because I'm tired of wasting my time playing these stupid games. Thanks.
Comment #10
star-szrFor me the decision about which issue to close as a duplicate is only ever hard when both issues have history, multiple people involved, etc.
If the issue is fresh, patch or not it gets closed as the duplicate when I am triaging. Triaging is one of my duties as a maintainer of the theme system component and I'm happy to do it and never upset about duplicates being filed. Finding issues can be very hard and I have a lot of issues in my head (haha) and can make associations.
The older issue has more people following it, credits are being established, and issue summaries are easy to update to add more info or completely revamp.
Thanks again for your contributions and although this explanation may not eliminate your frustration I hope you can respect the decision I made.