Adding File Usage "File" relationship results in broken/missing handler

Can you enable the display of errors on /admin/config/development/logging? This could give some more information to start with.
Are you sure you also don't see any kind of error in the javascript error console? Its often, especially in connection with ajax work, appearing there.

@usrsbn Please turn off JS aggregation on the performance admin screen, get us the exact console error. Also, there may be a web server PHP you could find.

There is, if you enable it, some error message involved, quite sure about that.

What is the server PHP error when that happens?

I've encountered this issue several times recently as well, with multiple 8.0.x tagged releases and HEAD.

In addition to the errors logged and noted by usrsbn, the following message is printed via the views_ui (though not logged... I'm not sure if there is something distinct to my logging setup that would explain that though):

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'fid' in 'field list': SELECT node_field_data.created AS node_field_data_created, node_field_data.nid AS nid, fid AS fid FROM {node_field_data} node_field_data WHERE (( (node_field_data.status = :db_condition_placeholder_0) )) ORDER BY node_field_data_created DESC LIMIT 10 OFFSET 0; Array ( [:db_condition_placeholder_0] => 1 )

This seems to occur under several different views configurations. Adding a "file usage" relationship simply appears to be impossible without resulting in a broken handler. I'm not aware of any current workaround.

I tweaked the issue summary slightly to capture error specifics.

Additional clarification to title.

Turns out none of the relationships defined in FileViewsData.php have an id set for the handler.

Did some quick manual tests and this seems to help.

But oh boy does this need some tests! (and a more generic way of adding these relationships? Hardcoded adding them only to all the known core entities? Really? Feels very D7).

Thanks Lendude, #12 fixed it for me in 8.0.3 and 8.1.0-beta2. My system is still in dev, so plenty of opportunity to test (and plenty of time to receive an official patch).

Any progress on this?

I tested the patch in #12 on Drupal 8.1.10, and it doesn't solve the problem. I still get the same error dialog, a similar SQL query error, and 21 log entries.

Yeah I'm also not convinced by that at all. We merge the standard relationship in there normally.

Thanks Lendude, #12 also worked for me in 8.2.1

#12 worked for me in 8.2.3. Thank you! Why isn't this fixed yet?

As a side note: It seems that the lines are off in 8.2.3; what I did was a manual patch, inserting " 'id' => 'standard' " after lines 129, 145, 164, 180, 200, 215, and 234.

Why isn't this fixed yet?

Needs tests and probably a better (as in, more generic) fix then the thing I did in #12. The fix in #12 is fine for people needing an instant fix, but as a real fix we want to look at something better, like what @dawehner said in #18

I m using drupal core 8.3.2 and this patch did not fix for me the error. Anybody knows or have any more patches for it?

/Takim

Re-rolled patch for 8.4.x.

Will see if I can add some failing tests. Also, should the standard handler be set as the default (in which case, the fix should be in Views)?

This contains a failing test for the file_to_user relationship. It can only pass if you apply the patch from #25.

This contains a failing test for the file_to_user and user_to_file relationships. It can only pass if you apply the patch from #25.

Lets kick the testbot into motion and see if it fails.

Hold on, I'm working on 2 new tests, and refactoring the first 2 :-). I'll upload the patch in a few minutes.

This refactors the tests, merging the 3 existing User/File relationship tests into a single Kernel test (instead of a Browser test), and adds a new Kernel test for Node/File relationships.

Again: these tests will fail unless the patch from #25 is applied.

Fix looks good to me. Not familiar with tests so can't mark as RTBC.

#12 works in D8.37.

Any plans to port this to D8.5?

Is this fixed in 8.5.0 somehow? I have one view that I know of (in addition to default files list) which has file_usage relationship and it seems to work now without the patch. Adding a new relationship for file usage doesn't print any errors either.
It was the patch #31 which was failing, #25 still applies. That's why it worked for me.

Any progress on getting this actually released?

Nice work on the tests. Bit of a clean up. This merges the fix and the tests.

I came across this bug in 8.5. A little confused if this patch will/should work in 8.5?

@nottaken I'm just testing core update 8.4.6 -> 8.5.1 and the patch applies and works on 8.5.1 too.

Just tested the patch in 8.5.1. When clicking in "adding fields" after the relationship is added, the field table where you can select the fields to be added has formatting issues, with the file fields all aligned on left and the others aligned on the right.

This problem keeps happening in the Drupal version 8.6.1
If the user only applies the FileViewsData.php patch , it works

Still occurring in Drupal 8.6.2, PHP 7.0.33, & MySQL 5.7.24.

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'fid' in 'field list': SELECT node_field_data.created AS node_field_data_created, node_field_data.nid AS nid, fid AS fid FROM {node_field_data} node_field_data WHERE node_field_data.status = :db_condition_placeholder_0 ORDER BY node_field_data_created DESC LIMIT 25 OFFSET 0; Array ( [:db_condition_placeholder_0] => 1 )

Notice: Undefined index: id in Drupal\views\Plugin\ViewsHandlerManager->getHandler() (line 104 of /home/user/public_html/core/modules/views/src/Plugin/ViewsHandlerManager.php)

I can confirm that I am getting this issue on Drupal 8.6.10 too.

Just tried patches 25 and #41 individually on my Drupal 8.6.17 site and it did not fix the issue.

On Drupal 8.7.5 I was able to apply #25 but it did not work. #12 and #41 could not be applied.

Here a patch for 8.7.*.

There were some changes that didn't belong in the patch I added. I removed them from the patch.

Hi all,
The patch (2628230-53.patch) has been tested against drupal core version 8.7.7
file relationship before applying the patch:

file relationship after applying the patch :

patch applied successfully

#53 applied to Drupal 8.8.1 fixes the problem.

It looks like #53 removed the test coverage that's in #41 - we need that test coverage in order to commit this fix and ensure we don't break this again.

This is at least a major bug - you can cause your site to error through normal operation.

Hi @alexpott, the test cases from #41 have been added to the patch from #53 and tested against drupal 8.8.1 .
it works fine.
2628230-65.patch

I can confirm, the patch from #66 works for my view file relationship.
After applying the path, clear the cache and add the relationship.

#53 (https://www.drupal.org/project/drupal/issues/2628230#comment-13213379) worked for me on Drupal core 8.8.3. #65 was failing to apply that patch using composer.

#53 works for me too. i have drupal 8.8.2

Another +1 for #53 on 8.8.1 - thank you :)

Works on 8.8.6. After applying patch, must clear the cache to make it work.

Patch from #65 does not apply to branch 8.8.x, not even to 8.8.1 tag. It looks like it got corrupted. However, I see it is exactly same as #53 except extra test cases and #53 still applies to current 8.9.x.

#53 worked for me with 8.9.2. Thanks

#53 worked for me with 8.9.8. Thanks.

This is such a important issue and must be resolved in Core 8.9.x

Didn't even open the patch file in #65 but since it is 18k and the patch in #41 is 40k, I'm pretty sure it's still missing things......

Oops, should have opened it! The old patch also included a move from simpletest to phpunit, sorry!

Started from scratch with #41 cause as far as I can tell all sorts of things got lost in other patches. Rerolled and refactored all the simpletest stuff. The file that gets removed is a test case that is moved from a functional test to the new kernel test, so no coverage is lost there, just some testbot run time won.

Opened an MR for this.

Opened up a branch/MR for test-only, not sure yet if that is the best way to handle test-only

#53 works for me. i'm using drupal 8.9.13

I ran into this error in 9.1.10 also.
I couldn't use the patch from #53 directly as the file is now slightly different... but adding the ID to all of the defined relationships appears to have fixed everything (with cursory testing).

It looks like this patch alone isn't enough. It lets me add the file relationship properly, but then the view query starts to throw errors.
Using PostreSQL - looks like it's some kind of conversion issue... but I'm a bit out of my depth here.

I'm running into this in Drupal 9.2.3

I'd try the patch in #53, but....

the problem is not solved

I m use Drupal 9.3.5, php 7.3 or 8.0
Adding File Usage "File" relationship results in broken/missing

Relationship: Broken/missing handler
The handler for this item is broken or missing. The following details are available:
Enabling the appropriate module will may solve this issue. Otherwise, check to see if there is a module update available.

Notice: Undefined index: id в Drupal\views\Plugin\ViewsHandlerManager->getHandler() (строка 104 из /var/www/www-root/data/www/otziv.dalem.ru/web/core/modules/views/src/Plugin/ViewsHandlerManager.php)

how do I solve it?

The patch from #53 applies fine to the current Drupal 9; remember to do a container rebuild after applying it.

How about just adding that patch to the next release, instead of keeping a major bug open for seven years because there is no test? How is that worse than actual broken functionality?

Patch #53 works on 9.4.5. What can we do to get this merged?

It looks like we need tests someone already wrote and the patch that everyone uses integrated into a single patch or a merge request.

It's been 7 years to this issue and seems its yet not fixed ? Weird.. I am on Drupal 9.4.8 and I am still facing this issue.. Any chance of getting the issue fixed soon ?

Patch in #53 applied successfully on Drupal 9.5.3, PHP 8.0.28

There are no patches in comment #53.

It is not clear why this issue has been changed to Needs work, but a comment that says the patch applies to Drupal 9.5 is not sufficient to mark the issue as Reviewed & tested by the community, especially because this is a Drupal 10 issue, now.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Adding the patch again for 10.1.x
The patch of #53 applies properly on 10.1.x
adding before and after patch images, for more clarity

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue under control, following Review a patch or merge request as a guide.

This ticket will need a test case to show the issue.

Howdy,

For what it's worth, after applying the patch in #99 to a Drupal 10.0.8 installation, the errors are gone and the (file) relationships work as expected in my views.

#99 or 53 fixes the issue for 9.5.9 when applied manually

Summarizing all the progress done so far.

Patch in #99 fixes the issue.

Patches from @Lendude #79 and #81 contains all the test cases.
However those got removed during next re-rolls.
One more attempt was done in comment #41, however #79 looks good enough to me.

Re-roll #65 also seems missing certain things.

I've combined all the progress, and performed necessary tweaks in test cases and patch.

I have included an interdiff, however it mostly contains all the test cases.
Also, included test-only patch for reference. We already have a PR which is failing.

Updated issue summary and hiding all other unnecessary patches.

I think I put views config files in incorrect folder and that is causing issues.
Fixing in the patch.

Also, missed a couple of module dependencies in code formatting fixes.
Adding those again. All the failing tests are passing on local now.

Removing depredations.

I've reviewed and tested the patch in #112, which includes tests. Looks like it's all in order. I've applied the patch with composer locally and then did a drush cache rebuild. The error disappears.

I'm not clear why this was switched to the 11.x-dev version back in #103. According to https://www.drupal.org/about/core/policies/core-release-cycles/schedule it seems that this bug fix could even go into 9.5.x. At the very least 10.0.x.

11.x is the current development branch. All code is committed there first and case by case backported to previous versions.

The fix looks right and was provided by one of the subsystem maintainers of Views 👍

The test coverage looks good 👍 Made a minor adjustments on commit to the modules installed for the test.

Committed b8e7644 and pushed to 11.x. Also cherry-picked to 10.1.x. Thanks!

This may be qualified for a backport to 10.0.x and 9.5.x but checking with other committer.

This commit has broken HEAD on 11.x and 10.1.x for pgsql only.

TestBot merrily gives us the middle finger with:

1) Drupal\Tests\file\Kernel\Views\RelationshipNodeFileDataTest::testViewsHandlerRelationshipFileToNode
Drupal\Core\Database\DatabaseExceptionWrapper: Exception in test_file_to_node[test_file_to_node]: SQLSTATE[42883]: Undefined function: 7 ERROR:  operator does not exist: character varying = bigint
LINE 5: ...ta" "node_field_data_file_usage" ON file_usage.id = node_fie...
                                                             ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.: SELECT "file_managed"."fid" AS "fid", "node_field_data_file_usage"."nid" AS "node_field_data_file_usage_nid"
FROM
"test20724246file_managed" "file_managed"
LEFT JOIN "test20724246file_usage" "file_usage" ON file_managed.fid = file_usage.fid
INNER JOIN "test20724246node_field_data" "node_field_data_file_usage" ON file_usage.id = node_field_data_file_usage.nid AND file_usage.type = :views_join_condition_0
LIMIT 11 OFFSET 0; Array
(
    [:views_join_condition_0] => node
)

/var/www/html/core/modules/views/src/Plugin/views/query/Sql.php:1563
/var/www/html/core/modules/views/src/ViewExecutable.php:1441
/var/www/html/core/modules/views/tests/src/Kernel/ViewsKernelTestBase.php:127
/var/www/html/core/modules/file/tests/src/Kernel/Views/RelationshipNodeFileDataTest.php:115
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

2) Drupal\Tests\file\Kernel\Views\RelationshipNodeFileDataTest::testViewsHandlerRelationshipNodeToFile
Drupal\Core\Database\DatabaseExceptionWrapper: Exception in test_node_to_file[test_node_to_file]: SQLSTATE[42883]: Undefined function: 7 ERROR:  operator does not exist: bigint = character varying
LINE 4: ...53file_usage" "file_usage" ON node_field_data.nid = file_usa...
                                                             ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.: SELECT "node_field_data"."nid" AS "nid", "file_managed_file_usage"."fid" AS "file_managed_file_usage_fid"
FROM
"test13514853node_field_data" "node_field_data"
LEFT JOIN "test13514853file_usage" "file_usage" ON node_field_data.nid = file_usage.id AND file_usage.type = :views_join_condition_0
INNER JOIN "test13514853file_managed" "file_managed_file_usage" ON file_usage.fid = file_managed_file_usage.fid
LIMIT 11 OFFSET 0; Array
(
    [:views_join_condition_0] => node
)

/var/www/html/core/modules/views/src/Plugin/views/query/Sql.php:1563
/var/www/html/core/modules/views/src/ViewExecutable.php:1441
/var/www/html/core/modules/views/tests/src/Kernel/ViewsKernelTestBase.php:127
/var/www/html/core/modules/file/tests/src/Kernel/Views/RelationshipNodeFileDataTest.php:177
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

See for example: https://www.drupal.org/pift-ci-job/2682293

Unsure if we need to do the Rollbak-Rumba, or attempt a hotfix in here.

It looks like the id column is a string whereas nid is an integer. Because of this, the patch only works with MySQL which is more relaxed about types. We need to decide whether we skip the tests for other database types than MySQL and fix this for other databases in a follow-up or revert this. The reason I think it might be fine to postpone fixing PostgreSQL to a follow-up is that the experience before and after this change is pretty much the same, it's just a different error that is being triggered now.

Posted a patch in a follow-up issue: #3364621: Drupal\Tests\file\Kernel\Views\RelationshipNodeFileDataTest fails on HEAD with PostgreSQL.