Problem/Motivation

See https://dispatcher.drupalci.org/job/staging_simpletest_job/283/ and https://dispatcher.drupalci.org/job/php7_postgres9.1/1/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

catch created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

Running Drupal\ban\Tests\Migrate\d7\MigrateBlockedIPsTest I get a core dump...

(lldb) target create "/usr/local/php5/bin/php" --core "/cores/core.72432"
warning: (x86_64) /cores/core.72432 load command 146 LC_SEGMENT_64 has a fileoff + filesize (0x2209f000) that extends beyond the end of the file (0x2209e000), the segment will be truncated to match
warning: (x86_64) /cores/core.72432 load command 147 LC_SEGMENT_64 has a fileoff (0x2209f000) that extends beyond the end of the file (0x2209e000), ignoring this section
Core file '/cores/core.72432' (x86_64) was loaded.
Process 0 stopped
* thread #1: tid = 0x0000, 0x0000000100970bc8 php`pdo_parse_params(stmt=0x0000000103f42700, inquery=0x00000001036cfc00, inquery_len=<unavailable>, outquery=0x0000000103f42768, outquery_len=0x0000000103f42770) + 2680 at pdo_sql_parser.re:220, stop reason = signal SIGSTOP
    frame #0: 0x0000000100970bc8 php`pdo_parse_params(stmt=0x0000000103f42700, inquery=0x00000001036cfc00, inquery_len=<unavailable>, outquery=0x0000000103f42768, outquery_len=0x0000000103f42770) + 2680 at pdo_sql_parser.re:220
   217 							zend_string *buf;
   218
   219 							buf = php_stream_copy_to_mem(stm, PHP_STREAM_COPY_ALL, 0);
-> 220 							if (!stmt->dbh->methods->quoter(stmt->dbh, ZSTR_VAL(buf), ZSTR_LEN(buf), &plc->quoted, &plc->qlen,
   221 									param->param_type)) {
   222 								/* bork */
   223 								ret = -1;
(lldb) bt
* thread #1: tid = 0x0000, 0x0000000100970bc8 php`pdo_parse_params(stmt=0x0000000103f42700, inquery=0x00000001036cfc00, inquery_len=<unavailable>, outquery=0x0000000103f42768, outquery_len=0x0000000103f42770) + 2680 at pdo_sql_parser.re:220, stop reason = signal SIGSTOP
  * frame #0: 0x0000000100970bc8 php`pdo_parse_params(stmt=0x0000000103f42700, inquery=0x00000001036cfc00, inquery_len=<unavailable>, outquery=0x0000000103f42768, outquery_len=0x0000000103f42770) + 2680 at pdo_sql_parser.re:220
    frame #1: 0x000000010096b643 php`zim_PDOStatement_execute(execute_data=<unavailable>, return_value=0x0000000101c270e0) + 579 at pdo_stmt.c:495
    frame #2: 0x0000000100b34747 php`ZEND_DO_FCALL_SPEC_HANDLER(execute_data=0x0000000101c26f20) + 1639 at zend_vm_execute.h:842
    frame #3: 0x0000000100b20738 php`execute_ex(ex=<unavailable>) + 40 at zend_vm_execute.h:417
    frame #4: 0x0000000100b20b5e php`zend_execute(op_array=<unavailable>, return_value=<unavailable>) + 1038 at zend_vm_execute.h:458
    frame #5: 0x0000000100adf84b php`zend_execute_scripts(type=8, retval=0x0000000000000000, file_count=3) + 315 at zend.c:1428
    frame #6: 0x0000000100a7bc94 php`php_execute_script(primary_file=0x00007fff5f50c220) + 852 at main.c:2471
    frame #7: 0x0000000100b73000 php`do_cli(argc=<unavailable>, argv=<unavailable>) + 4048 at php_cli.c:974
    frame #8: 0x0000000100b71eb7 php`main(argc=<unavailable>, argv=<unavailable>) + 1399 at php_cli.c:1345
    frame #9: 0x00007fff8a9e65c9 libdyld.dylib`start + 1
(lldb)
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented

pgsql91 + php7 is enabled for testing for core btw.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

@Mixologic did you compile with a native driver or PDO - ie. --with-pgsql or --with-pdo-pgsql?

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented

The Dockerfile shows --with-pdo-pgsql

http://cgit.drupalcode.org/drupalci_testbot/tree/containers/base/php-bas...

Fabianx’s picture

Fabianx CreditAttribution: Fabianx at Tag1 Consulting commented

Reported as https://bugs.php.net/bug.php?id=70861. Will provide PHP devs with reproducible environment as usual :).

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch as a volunteer commented
Fabianx’s picture

Fabianx CreditAttribution: Fabianx at Tag1 Consulting commented

https://bugs.php.net/bug.php?id=70861 is fixed upstream, so we can tomorrow re-run the whole test suite on DrupalCI with PG SQL.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx at Tag1 Consulting commented
Parent issue: » #2454439: [META] Support PHP 7

Opened https://bugs.php.net/bug.php?id=70866 after discussion with 'ab' in IRC.

All follow-up work (a pile) to https://bugs.php.net/bug.php?id=70861 that I reported as https://bugs.php.net/bug.php?id=70862 is fixed as well! :)

It was worth to follow-up on that as it discovered some edge case bugs that Drupal 8 might have encountered later in the game.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch as a volunteer commented
Status: Active » Fixed

https://www.drupal.org/pift-ci-job/86058 now green, marking fixed!

Fabianx’s picture

Fabianx CreditAttribution: Fabianx at Tag1 Consulting commented
Status: Fixed » Postponed (maintainer needs more info)

Actually lets use postponed.

While Drupal-CI is green, my testbox still fails (and passes with PHP 5).

That points to a memory corruption likely.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: -rc target

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Closing as outdated since this moved to PNMI 7 years ago.

Also with. D10 moving to php8.1 wonder if this is still an issue.

If still an issue with php7.4+ please reopen with updated issue summary.