In Drupal\system\Tests\Update\UpdatePathRC1TestBaseFilledTest::testUpdatedSite running updates is not being executed. If we run the updates on the current head without any changes everything should be fine, but unfortunatelly it is not and the test for checking that the entity schema is up to date fails.

This one is not causing any data loss but something looks wrong in the head, so I am prioritizing it as critical until it is clear what is wrong. I guess something got in after RC1 was out without checking for entity schema updates.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hchonov created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, run_rc1_updates.patch, failed testing.

hchonov’s picture

The patch from #2602996: Upgrade path for #2597628 solves the issue here.

alexpott’s picture

One thing that is really interesting is that Drupal\system\Tests\Update\UpdatePathRC1TestBaseFilledTest is failing but Drupal\system\Tests\Update\UpdatePathTestBaseFilledTest is not.

catch’s picture

Is it possible that this is because the RC1 update is actually beta12 -> RC1 -> RC2 - which would be exactly the head2head scenario that #2602996: Upgrade path for #2597628 fixes.

#2600086: Create a script to generate a filled database dump and use it to replace the pseudo-RC1 one we currently have would be useful.

plach’s picture

Status: Needs work » Needs review
FileSize
0 bytes

Probably. Let's see :)

plach’s picture

The last submitted patch, 7: entity-schema_updates_rc1-2607364-7.patch, failed testing.

catch’s picture

Status: Needs review » Needs work

In that case I think we should promote to #2600086: Create a script to generate a filled database dump and use it to replace the pseudo-RC1 one we currently have to critical - since our upgrade tests don't test the actually-supported upgrade path.

And the fix for pre-RC1 databases can stay in head2head.

effulgentsia’s picture

Promoting #2600086: Create a script to generate a filled database dump and use it to replace the pseudo-RC1 one we currently have to Critical might be overkill for this issue, but a good idea for its own reasons.

If we want to resolve this issue prior to that one, can we simply fix drupal-8-rc1.filled.standard.php.gz by taking what's there now, running #8 or similar on it, and re-exporting that?

catch’s picture

Title: RC1 running updates on a clean head leads to a test failure indicating entity schema is not up to date » RC1 filled database update fails due to beta-12 to RC1 upgrade path issue

Let's retitle for the actual bug.

I'm neutral on #11, it means we could run the test without failures, but it makes that database even more of a monster.

plach’s picture

Status: Needs work » Active

I think we should either go with #11 or close this as a duplicate of #2600086: Create a script to generate a filled database dump and use it to replace the pseudo-RC1 one we currently have and make it critical.

plach’s picture

Status: Active » Needs work

Personally I'd be fine with an incremental fix.

I'm neutral on #11, it means we could run the test without failures, but it makes that database even more of a monster.

It's just matter of "dropping" a couple of inserts, I think, no need to run #8 actually.

plach’s picture

Assigned: Unassigned » plach

Trying #14.

plach’s picture

Assigned: plach » Unassigned
Status: Needs work » Needs review
FileSize
865.41 KB
2.59 KB

Here it is

plach’s picture

I forgot to rebase before rolling the full patch, the review patch in #16 is correct.

The last submitted patch, 16: entity-schema_updates_rc1-2607364-15.patch, failed testing.

catch’s picture

Status: Needs review » Reviewed & tested by the community

OK, let's get this in since it's an improvement on the status quo.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed c4149af and pushed to 8.0.x. Thanks!

  • alexpott committed c4149af on 8.0.x
    Issue #2607364 by plach, hchonov, catch: RC1 filled database update...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.