Problem/Motivation
https://www.drupal.org/drupal-8.0 claims we have more than 200 new features and improvements but does not let us know which ones. Of course the changelog http://cgit.drupalcode.org/drupal/tree/core/CHANGELOG.txt would tell us. Uhm, no. It has not been kept up to date in a loooooong time. This is the kind of magic number that will be repeated in the press and blogs, and we'd better have a list to show for it. Anyway, we need to keep our changelog useful if we appear to have an entry for Drupal 8 :)
Proposed resolution
Fill in the missing pieces, fix the wrong elements in the changelog.
Remaining tasks
Reviews, additions, reviews, more additions and reviews :)
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#118 | 2606334-version-tag.patch | 334 bytes | effulgentsia |
#83 | interdiff.2606334.77.83.txt | 1.38 KB | YesCT |
#83 | 2606334.83.patch | 15.81 KB | YesCT |
Comments
Comment #2
Gábor HojtsyComment #3
davidhernandezWhat is the qualification for something to be included?
First line has the tpl.php conversions. We could add that all theme functions have been converted, as well. Also, the addition of Classy and Stable.
There are some new modules missing, like the menu link change and the caching ones?
Comment #4
dawehner* Added PHPUnit for proper unit testing, see https://phpunit.de/manual/4.8/en/index.html so you can run tests via your IDE
* Added BrowserTestBase as an alternative to simpletest for browser testing (Javascript included in the future)
* Added KernelTestBase to provide a fast API testing of integration of different components
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedIn addition to noting that translations get downloaded in the installer I think it is important to mention that "the installer is presented in the user's native language according to their browser preference". IMO, this is huge.
Comment #6
Gábor Hojtsy@RyanWeal: So the included "Automated import and update of translations in the installer and later." may not be the best wording for that, any better suggestions?
@davidhernandez: I think "higher level" changes are meant to be here. The ones you list seem to be all valid to be included IMHO. I would not list specific API changes. So in that sense, maybe we should remove some of the translation API items :D
Comment #7
Gábor HojtsyThanks for the feedback so far. Here is an update based on those.
1. Grouped frontend changes. This is now listed as the first item for easier reviews. Not sure we want to keep it first. Added some there and moved existing ones there. Need reviews and additions :)
2. Added a testing section as per suggestions from @dawehner.
3. Fixed the items mentioned by @Ryan.
Comment #8
attiks CreditAttribution: attiks at Attiks commentedAdded responsive images
Comment #9
dawehnerAdded a bit more around the symfony components.
Comment #10
star-szrI think we should note that this is the default base theme. "used as the default base theme." maybe.
As for other frontend changes, here are some in no particular order (just numbered for discussion purposes). Not sure the level of detail we want, feel free to reject some of these as too granular:
Edited to make one addition.
Comment #11
Gábor Hojtsy@Cottser: I think that is fine granularity unless there are a dozen more on that granularity :D If that's it, then I personally think we can include them :)
Comment #12
star-szrMissed an important one:
All page variables (title, tabs, etc.) converted to blocks
Comment #13
LewisNyman* Modernizr has been added that allows us to make styling changes based on browser support.
Comment #14
davidhernandezAdded some frontend changes.
Comment #15
Gábor HojtsySo that includes most of Cottser's suggestions, thanks! Did you discuss not including the rest offline or crossposted? :)
Comment #16
davidhernandezNope. I wasn't sure if they really needed to be included, due to the granularity, or how to describe them properly so I left them out. Low hanging fruit I suppose.
Comment #17
YesCT CreditAttribution: YesCT commentedI'm not suggesting including all the things, but we might look at these places to get inspired/reminded of things to put in the change log
general things from the front page of https://api.drupal.org/api/drupal/8
closed fixed major and critical feature requests https://www.drupal.org/project/issues/search/drupal?project_issue_follow...
modules removed https://www.drupal.org/node/2116417
modules added https://www.drupal.org/node/2164623
I think change records are a new thing since 8.x started.
The changelog.txt file should mention https://www.drupal.org/list-changes/drupal
and maybe describe a bit of what the difference is there vs the changelog.txt file.
Comment #18
YesCT CreditAttribution: YesCT commentedComment #19
YesCT CreditAttribution: YesCT commentedComment #20
chx CreditAttribution: chx commentedNeeds to be removed as we require PHP 5.4.0 and that version nuked these two
Comment #21
YesCT CreditAttribution: YesCT commentedyeah.
also, I think we can remove
"Drupal 8 can no longer be installed on hosts with the 'magic_quotes_gpc', 'magic_quotes_runtime', or 'safe_mode' PHP ini settings turned on; these settings are deprecated in PHP 5.3 and have no effect anymore in PHP 5.4 and higher."
from
https://www.drupal.org/requirements/php#8
since d8 requires a min php version of 5.5.9 anyway ( https://www.drupal.org/requirements )
Comment #22
Gábor HojtsyOTOH we should say something about "supporting" PHP 7? :)
Comment #23
skyredwangI have tested all PHP 7 RC releases so far. I haven't found any problems on D8 yet.
Comment #24
chx CreditAttribution: chx commentedComment #25
yoroy CreditAttribution: yoroy as a volunteer commentedSome ux changes worth calling out:
Shiny new installer
Redesigned content creation form
Updated and extended Seven admin theme
Responsive admin toolbar
Comment #26
thamasDrupal does not load automatically any (vendor) library (eg. jQuery) for better performance.
Comment #27
bojanz CreditAttribution: bojanz at Centarro commentedI'd highlight the fact that we support Composer. It's usually a big deal to external developers.
Once #2608174: Update composer-merge-plugin to latest version lands, we will be able to use Composer not just to download libraries, but also Drupal modules, with no additional tools (other than adding the Drupal Packagist repository). That's a very big workflow improvement/change.
Comment #28
gaele CreditAttribution: gaele commentedIt's not dramatic. Are you American? :-)
Comment #29
MustangGB CreditAttribution: MustangGB commentedShould "Phone number" be called "Telephone number"?
Comment #30
larowlanAdded some stuff I'm proud of contributing to that we'd not covered.
Comment #31
nevergone CreditAttribution: nevergone commentedtypo
Comment #32
joelpittetSuggestions:
And yes @MustangGB it should be because that is the name of the module, good idea.
Comment #33
Wim LeersEDIT: includes #26.
Comment #34
Wim LeersComment #35
catchCrosspost with Wim...
Comment #37
dawehnerA sandbox for just that could be actually useful.
Expanded the views section a bit.
Comment #38
dawehnerIts certainly on needs review ...
Comment #39
star-szrFound some nits and things. Great to see all this in one place :)
As for collaboration maybe something like an etherpad or google doc? ¯\_(ツ)_/¯
Nit: This should end in a period or colon or some kind of punctuation.
based = based on?
Why are Menu and Local capitalized here?
Add an oxford comma here before the "and" - "schema, dependencies, and validation"
I would suggest removing "but also" and replacing it with a comma but maybe that's just me.
In both cases I think these would read better if "Allows to" was removed.
Is there duplication here? Routing based on Symfony2 components is mentioned above… just checking.
s/api/API/
s/Rewritting/Rewrote/
Typo in the first place, but present tense doesn't seem to make much sense here to me.
Should have a comma before "and" again, see https://www.drupal.org/drupalorg/style-guide/content.
"the jQuery UI team" I think, and then maybe just "the Views team"? If it's not the Views team I think this sentence could use some rethinking because it sounds like "the Views UI" is a group of people which would be odd :).
s/soliticing/soliciting/
s/Javascript/JavaScript/
Comment #40
Gábor Hojtsy@Cottser: IMHO feel free to update the patch :) As for collaboration, I would personally favor committing from this issue multiple times to make incremental changes easier to review. Not sure a google doc would make it clear who changed what/when/why. It also would not end up in issue credits/commit credits without the respective people commenting / posting patch updates in a similar quantity here.
Comment #41
Gábor HojtsyAlso there are several comments with valuable insights that I don't think are integrated in the patch. Eg. from chx, bojanz, thamas, yoroy, etc. Does someone want to step up to champion the inclusion of those. We only have 3 days to release now :)
Comment #42
catchI'm OK with multiple commits from here, let's address #39 first though then get what we have in?
Then we can keep going for #41 onwards?
Comment #43
star-szrMultiple commits does sound better. Here's everything from #39 but #39.7, left as is because I'm not sure if it's duplication or not.
I do agree with @joelpittet in #32 that the Attribute thing is worth mentioning, and probably autoescape too. We already have the blocks stuff covered:
* All page template variables converted to blocks.
Comment #44
star-szrOh I missed this, stray bullet point got introduced somewhere.
Comment #45
Gábor HojtsyEmpty lines are not supposed to be added. Apart of that, looks RTBC for what we have now. We can and will/should iterate on this further once this lands.
Comment #46
catchCommitted/pushed #45.
Back to 'active' for more updates.
Comment #48
MustangGB CreditAttribution: MustangGB commentedFeel free to include #29.
Comment #49
dawehner+1 for the approach to improve things over time!
Comment #50
Gábor Hojtsyre #17: - added a note at the top, reviewed the list of removed modules, they are all here; did not yet ensure all the added modules are represented
re #24: - addressed all points (some were already), except PSR-0, we don't claim we use those components :D
re #25: - all done, great stuff :)
re #26: - already done
re #27: - added a short not on Composer, improvements welcome
re #28: - changed it to "Significantly" ;)
re #29: - changed it to "Telephone"
re #32: - added the auto-escaping one, I think the HTML attribtues may be a detail(?), the blocks are already there :)
Finally indented things consistently and used consistent second level list item markers (* instead of -). And where I needed to change/add things I also reworded with an active verb to start with in the usual form of the changelog elsewhere :)
I think this catches up with all suggestions so far with the notable exception of not all added modules mentioned :)
Comment #51
joelpittetNice consolidation @Gábor Hojtsy. Likely big enough for an commit iteration, though I'll give it more than 15 min;)
Comment #52
Gábor HojtsyRan through the new modules and added the following:
- automated cron
- ban
- breakpoint
- custom menu links
- text editor
Also reworded the editor items a bit while I was there to active verb changelog format. And added a "Made media management (a little) easier" (we need to be honest there I think, its small changes). There are probably other small goodies lying unmentioned still :) Any good ideas?
Comment #53
larowlanadded security section based on chat in #drupal-security and using https://dev.acquia.com/blog/drupal-8/10-ways-drupal-8-will-be-more-secur... for some inspiration
Comment #54
Gábor Hojtsy1. Re @larowlan: Remove now double mention of PHP filter and autoescape in twig :) When did core support import config through PHP? I am not sure that was a core feature?
2. I remembered Dries had a list of features in a keynote and that was worth checking against :) Indeed. Several good ones that we forgot earlier: responsive tables (also in views), schema.org output, semantic HTML 5 tags, retina compatible icons, searchable and better readable module list, drag and drop file uploads, simple VBO :) BTW video at https://www.youtube.com/watch?v=8uhNFoOnz_g
Comment #55
Gábor HojtsyAlso @larowlan you made me think of custom comment types too :) So comments got their own section. And I integrated the image filter into the media portion now.
Comment #56
Gábor HojtsyFixed the mention of the PHP filter for blocks and adding configurable view modes, which is also new to D8 :)
Comment #57
Gábor HojtsySacrifice some too low level items from the language section, only keep the bigger ones. Did miss the possibility of language fallback in interface translation, added that.
Stopping for tonight :)
Comment #58
catchIs it worth mentioning that a lot of declarative information (libraries, permissions, routes etc.) has been moved from PHP to YAML?
Statistics module view counting works with the page cache and reverse proxies now.
Comment #59
Gábor HojtsySorry could not resist mentioning actual previews and semantic versioning. Also updated some key points with examples while I was at it. All inspired by the D8 slideshow (which honestly will need to get updated with some of this info we collect here :D) Aaaand really stopping for tonight :D
Comment #60
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedCan we add two extra "-" here so it's even with the line above? :) (We actually just fixed that throughout CHANGELOG.txt not too long ago.)
This is out of place here. If it belongs in CHANGELOG.txt, it should be in an intro section at the top of the file or something like that (not in the Drupal 8.0.0 section). It seems like a good idea though.
This is confusing... I think maybe it's trying to say: 'Removed the Overlay module from core and replaced it with a simple, dynamic "Back to site" link.'
Remove "too".
I am not sure what it means to "complete the field API" but it sounds inaccurate by definition :) Maybe just "Improved the field API and entity query API"? (Or make them separate bullet points.)
Not added in this patch, but "data-integrity" => "data integrity".
That looks pretty odd. Why not just "Improved media management"?
The last sentence especially (which isn't even a sentence) seems out of place here. Maybe the whole thing could just be "Made it possible to instantly upload files via drag-and-drop"?
I found that sentence confusing. Not sure the best way to reword it, but maybe "Added a language fallback capability to the interface translation API"?
Something's wrong here... at least replace the last part with "each of which can be configured with a different set of fields", I think.
Something's wrong with that sentence... How about "Converted various core listings to views, including /node, /admin/content/node, /admin/people, and several blocks"?
Should be "Added the ability to place all blocks multiple times on the same page"?
Views is part of Drupal, so "and the Views team" doesn't make any sense here. Just leave that part off.
It was always possible to turn off...
"Moved the automated cron execution functionality to its own module" is enough to say here by itself, I think.
"Secure" is really ambiguous here. I would just leave that word out.
This should not be here since it wasn't introduced in Drupal 8 (see http://cgit.drupalcode.org/drupal/tree/CHANGELOG.txt?h=7.40#n53). However given #2489672: Limit all DB drivers to executing single statements by checking for delimiter this could instead maybe say something about adding similar protection for non-MySQL drivers?
Also, "SQLi" => "SQL injection".
Let's be careful with this one. We don't autoescape everything, and what we do isn't limited to Twig. I would say something like "Added an autoescape API to prevent cross-site scripting in many of the places where Drupal outputs HTML"...
Too much capitalization; not enough words :) How about something like "Made the core JavaScript API compatible with Content Security Policy (CSP)"?
Not sure what this refers to security-wise... probably needs to be more specific if it's going to stay in this section.
Hm, I guess it's time to revive #1762708: Update CHANGELOG.txt to contain up-to-date entries from previous versions of Drupal also.
Comment #61
Gábor Hojtsy@David: Thanks for the review. Done all the things with these notes:
8. Changed that to "Made file uploads immediate when selecting files in file fields.". As @wimleers pointed out, it is not really drag and drop specific.
9. Ok, done. Once we put it that way, it also needs to move to the API section of the multilingual section :)
19. Removed. It is also in the authoring experience section with different wording, so we don't need to duplicate it.
DID NOT do these:
2. Not sure adding it above 8.0.0 would be useful, it is not really an over-arching improvement, you cannot learn much about Drupal 7 or 6 changes with change notices, they were mostly used for Drupal 8. I can remove it if its out of place. YesCT suggested it.
4. But they don't look bad on other displays :) They look good ALSO on retina displays.
12. No, its not about the same page. You can place a block to a sidebar on one page or set of pages while the same block may be in the footer on another set of pages page.
20. Indeed, different issue :)
Comment #62
Wim LeersThanks, this is more accurate. But it's still worth calling out the support for uploading multiple files simultaneously!
Comment #63
Gábor HojtsyAdded that back.
Comment #65
Gábor HojtsyAddressed #58 which was the only one outstanding. Thanks @catch!
Any other reviews, concerns, feedback? Missing items? Things to reorganize? :) I ran out of lists and things to look at. Compared this to the D8 slideshow at drupal.org/8, to the feature list at https://www.drupal.org/drupal-8.0/features, to Dries' Prague keynote, where he cited several features, to the major/critical feature requests list that YesCT provided, against the list of removed and added modules (and the modules themselves in Drupal 8). Not sure where else to look for things we missed or if someone has stuff in mind we don't have yet? :) Not that I don't think the existing set of things is not a mind-blowing collection, just want to make sure we give the chance for all the things :)
Comment #66
YesCT CreditAttribution: YesCT commentedI'll review this now. (maybe we can get another intermediate commit)
Comment #67
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedThere are some for Drupal 7; however my bigger point is that it applies to future releases also (e.g. 8.0.1 and beyond). There is nothing about change notices that is specific to the 8.0.0 release so it looks pretty out of place to me there.
Honestly I don't think anyone would be confused by that - it's not like we'd want to make them worse elsewhere :) I guess it's OK as is, but I did find the "too" to be confusing.
Hm, right. So how about "Added the ability to place the same block in multiple locations" or something like that?
This isn't as good as the previous one, in my opinion. It is still worth mentioning drag-and-drop even though it's not the only way. How about something like "Made it possible to instantly upload files, including via drag-and-drop"?
"statistics" => "Statistics", but also... isn't that new (first) bullet point referring to #1209532: Count node views via AJAX in the statistics module which is already in Drupal 7? I think the only difference is that it's on by default in Drupal 8 (but not Drupal 7). Not sure that difference is really worth mentioning.
Comment #68
effulgentsia CreditAttribution: effulgentsia at Acquia commentedWe're in the final home stretch of preparing 8.0.0, and we won't be committing the majority of "rc target" issues any more, but still leaving the tag on them to triage them for patch-release or minor-release post 8.0.0 release. Meanwhile, switching to "8.0.0 target" for issues we'd still love to get in before 8.0.0.
Comment #69
Gábor Hojtsy@David: re #67:
1. This update is for the 8.0 release. We can and should update it for further releases in which case we could reword this. I don't think moving it out of the 8.0 section without additional explanation would work. It would need to explain how it mostly applies to Drupal 8 and only somewhat to 7 but not to anything before it. Let's remove it then.
2. Let's leave it then? I think its a good sign if we show that we do think of the non-retina, not-latest, not-enterprise, etc. :)
3. Done.
4. We had a lengthy argument about this with @WimLeers in the morning. His point was that drag and drop was not made any better and especially not *introduced* in D8, its a browser feature. That the file field works with drag and drop is not a Drupal feat it was already in the browser. (You can drag and drop a file into a D7 file field too, but it will not upload automatically). D8 made automated upload and multiple file upload support available but not the drag and drop. Also as for your suggestion its not like we made it possible to immediately upload the file, its the only way that it works now. Its not a possibility, its how it is. I think "Made it possible to instantly upload files" (your suggestion) suggests that it may be uploading instantly or maybe not (depending on configuration or PHP code or something). So for now removed the repetition of "file, file, file" there.
5. Rolled that back then (except removed "from core" because all the changes are core).
Comment #70
YesCT CreditAttribution: YesCT commentedoxford comma here also.
standard file format.
"standard"
maybe simple instead or just take out the adjective.
comma after add (before and)
adding "the" so: "Added the Text Editor module"
fix english a bit so is a sentence.
keeping the capital on the module name.
including on
including for
?
I think we can remove also.
Comment #71
YesCT CreditAttribution: YesCT commentedI'll make those changes now.
Comment #72
YesCT CreditAttribution: YesCT commentedI looked at the whole patch, and the changes mostly look accurate and the wording is good.
someone please check my interdiff.
I dont think it is ok to have a changelog and not have a pointer to where people can actually find all of the changes: the change records.
How are people supposed to discover our change records?
But we can discuss that later, I'm ok with a commit without it.
Comment #73
YesCT CreditAttribution: YesCT commentedbased on feedback from @dawehner in irc (standard YAML redundant), so taking out the standard and being specific about which standard. :)
Comment #74
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedHow about instead of that "intro", just add a single bullet point at the bottom?
The problem is still that that link isn't (and never will be) specific to 8.0.0 but at least that would get it into the list, in a way that's consistent with the "catch-all" bullets points at the bottom of existing CHANGELOG.txt entries.
In fact we could add those catch-all bullet points too (certainly they are true), so maybe:
Comment #75
tim.plunkettWishful thinking, sadly. Only applies to content entity types.
Comment #76
YesCT CreditAttribution: YesCT commentedI'll make those change now.
(maybe when after some change record improvements we can have a link that applies a filter by version that is useful. right now... it's not so much)
Comment #77
YesCT CreditAttribution: YesCT commentedaddressed #74 and #75
Comment #78
YesCT CreditAttribution: YesCT commentedhere is the meta I was thinking of: #2292469: [meta] Improve change records
and this child might be the one that would result in an argument to the url for change records where a version can be given: #2289073: Make it easier to find change records that are relevant for major version upgrades
Comment #79
YesCT CreditAttribution: YesCT commentedwe could add custom blocks to the list before the etc.
Comment #80
larowlanyeah cause only nodes and custom blocks are turned on by default
Comment #81
plachThese two look weird in combination.
I may be biased but shouldn't we mention that the entity schema is now fully managed by the system? ;)
Comment #82
YesCT CreditAttribution: YesCT commentedThanks @larowlan and @plach
I'm going to make a new patch now.
Comment #83
YesCT CreditAttribution: YesCT commentedAdded the custom blocks.
I checked "Included the HTML5 Shiv library" was an old entry (the line was moved around in this issue in an earlier commit). I think it makes most sense to remove it given we are removing IE 8 support.
got help from @alexpott and @catch for the wording of the entity schema line. thanks!
let's get this a review!
Comment #84
plachThanks, this looks ready to go to me, but I have not enough knowledge about all the D8 changes to RTBC it.
Comment #85
dawehnerYou know, we can iterate for ages, let's get the improvements in!
I was about to mention that we could add that you can also search on the testing page, but this is not strictly a site administrator experience ;)
Maybe also mention menu links?
Comment #100
YesCT CreditAttribution: YesCT commentedtestbot just retested all the patches when the change went to rtbc... [edit: those interested might want to see #2598438: Improve logic and/or UI around retesting patches in RTBC issues and patches can be hidden as a workaround]
the fail on #83 can't be failing cause of changes to changelog.
https://www.drupal.org/pift-ci-job/84616
head: https://www.drupal.org/pift-ci-job/84336 was earlier
and there haven't been any commits since then.
so I'm gonna reset this to rtbc.
Comment #114
tim.plunkettComment #115
YesCT CreditAttribution: YesCT commentedThanks @tim.plunkett for hiding the old patches so they are not retested and for removing allll the test fail messages on the old patches that are not relevant :)
Comment #116
effulgentsia CreditAttribution: effulgentsia at Acquia commentedThis looks great. Thanks for everyone's contribution to this! Ticking everyone's credit box but mine.
Comment #118
effulgentsia CreditAttribution: effulgentsia at Acquia commentedI pushed #83 to 8.0.x. But before marking this Fixed, here's a patch to set the exact version and date. Just uploading it as a reminder for @catch to do this prior to tagging.
Comment #119
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedHe'll probably want to look at https://www.drupal.org/node/721106 for that :)
Comment #121
catchCommitted/pushed to 8.0.x, thanks!