Views RSS view mode settings are completely broken

Moving out of base system.

+++ b/core/modules/node/src/Plugin/views/row/Rss.php
@@ -68,8 +68,7 @@ public function __construct(array $configuration, $plugin_id, $plugin_definition
+    $options['_views.rss.title'] = $this->t('Title only');

This underscore feels a little bit odd, given that nothing seems to be using it?

I don't understand this issue from the summary. Some STR might help, as it currently reads as though it's removing an important feature. The summary should also document the case for making this change during RC and what the impacts/disruptions are. Thanks!

Updating the title for now.

Rerolled following #2409413: Remove fields that do nothing from the "RSS publishing" settings form, but this still needs an upgrade path and tests. We can remove the entire RSS publishing config form now.

Added post_update hook to delete the config entirely. Not sure what we should do about the pre-existing system_post_update_delete_rss_settings(), if anything.

Added a test and fixed the other update tests by removing the previous post_update hook code.

Still needs an upgrade path.

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

This blocks #3422904: Add validation constraints to all system.* simple config (except system.rss) and #2952037: [meta] Add constraints to all simple configuration.

Pushed to a MR with some small changes.

Upgrade path is tested afaik, so removing that tag. Has tests it seems, so removing that tag also. Did small update to IS, but don't see how we can make this more clear.

This will need a CR though. Dont think we need to deprecate anything really, since this is pretty much broken functionality you cant rely on.

Added a change record.

All tests are green. Which is great.

Not sure about the upgrade path. I'll ask around

Any existing views that have default as the RSS view mode need to be updated so they store whatever the default value actually was, before we delete that value from config. The default value is likely broken in many cases but doing this won't make it any more broken nor will it break existing sites that by coincidence do have it working for some reason, e.g if the default is teaser and they do have a teaser view mode.

Little more context; https://drupal.slack.com/archives/C079NQPQUEN/p1744791038514039

Well, seems i have a working test. While going through the motions i did find a one more view that use default still.

views.view.taxonomy_term.yml

      row:
        type: node_rss
        options:
          relationship: none
          view_mode: default

Also a little confused. If i look at system.rss.yml the default should be rss i think, since that was in the config. But when running the update test it gets set to title, i really don't understand how that is possible. What am i missing there?

fixed tests, so setting to NR

Left a couple of (reasonably horrible) questions on the MR.

Responded to @catch's review, NW for these changes.

I've got some questions about your approach, there might be more gotcha's (and possibly a bug :P)

Still need to handle 2 things:

1. When default is the viewmode, and we have no config this will keep updateing to the first key. What if there is actually a viewmode that is called default, do we keep that?
2. Run this onSave

Now running on onSave in the updateAll method.

Also added an extra check for when we have no reference from system.rss and there is an available view_mode called default.

Made selection code better and added comments on how it works.

Getting a failure on the Configuration tests. But not sure why, perhaps because the fixtures need to change since default config changed for taxonomy config?

Opened #3522801: Deprecate RSS usage in core to discuss if we want to deprecate RSS more broadly in core

Fixed a typo in the comments but otherwise this looks great, thanks for working through the pain of the update hooks and adding the test coverage for that - glad to see the back of this finally.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Bot is broken

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

GitLab also says there is a merge conflict?

Oh, will rebase later today.

I normally search like this: https://git.drupalcode.org/search?group_id=2&scope=blobs&search=-path%3A...

Since when are we opening issues on contrib projects for deprecations/removal? I've not seen that before :)

Updated CR

Mis understood, RTBC was referring to the change record.

But still made 2 child issues for those modules.

Added the requested docs.

https://drupal.slack.com/archives/C079NQPQUEN/p1747131446995239 slack thread

Gonna try again.

Failures were just blips. Setting back to RTBC

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Rebased and resolved the small conflicts. Also fixed phpunit annotation, those needed changing.

Implemented the small fix by @alexpott

Setting to RTBC because fix is small

Yay! Thank you guys. This was a hard one :)