Problem/Motivation

The explanation texts on the Configuration page invite the user to do something, for example to manage or configure something.
Some of these texts don't follow the common format, as described in the Help text standard; others are not correct anymore for Drupal8.

Account: it's not the users that are configured, plusO emails should be email messages
Language: Configuration can be separated separately in D8 and needs adding
Path: Aliases are added, they don't change URL. The hook help makes an explicit point that this should not be confused with "changing URLs"
Aggergator: No option for categorization. Plus confusing wording
Simple test: Should be one sentence. Question raised about using "assure"

Proposed resolution

Change the descriptions in the *links.menu.yml files that they are correct, consistent, and follow a common format.

Remaining tasks

Update the link descriptions for the listed modules.

User interface changes

This are UI text changes.

API changes

None.

Data model changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because the link descriptions are not correct for D8
Issue priority Normal
Disruption None
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ifrik created an issue. See original summary.

ifrik’s picture

Title: Update module descriptions on the Configuration page that are not correct for D8 » Update link descriptions on the Configuration page that are not correct for D8
ifrik’s picture

Assigned: ifrik » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
FileSize
2.95 KB
ifrik’s picture

I've corrected the link descriptions in several modules either because it wasn't correct or because the format was not correct.
I've tried to get around the "ensure/assure" question by using "review" instead.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

All of these changes look excellent to me, and I think they all make the links more correct, without adversely affecting usability.

Note: we may need to credit some people from the parent issue, but it is hard to tell who worked on this portion.

jhodgdon’s picture

ifrik says we should credit: mairi, snehi, rachel_norfolk (as well as ifrik)

Bojhan’s picture

Status: Reviewed & tested by the community » Needs work

I am not sure about "existing internal paths". We should be pointing to the fact you can "change existing URL's". Because that is what this is primarily for.

jhodgdon’s picture

Hm. Is it really changing URLs, or just adding additional ways to access them?

ifrik’s picture

The Path module adds an addititonal path to an existing system path.
The original path still exists and works - so it is not changed.

And in the help text, we made a point that Path does not change the URLs, and should not be confused with redirects which actually change the path.
So using "change" in the link description here, would be wrong.

"Existing system path" is the wording used on administration page of the module, but I didn't want to use "system" in the short description, because I thought that would be confusing.
I added "internal" just to make sure that it's obvious that it's only for paths that are in the site.

So in short: I can take out "internal" or replace it by "system", but we cannot use "change" here.

alvar0hurtad0’s picture

Status: Needs work » Needs review
FileSize
480 bytes
480 bytes

this is the patch with the #9 proposed solution

Status: Needs review » Needs work

The last submitted patch, 10: update_link-2578989-10.patch, failed testing.

The last submitted patch, 10: update_link-2578989-10.patch, failed testing.

alvar0hurtad0’s picture

Status: Needs work » Needs review
FileSize
2.94 KB

Ups,

I've attached the same file. This is the real patch.

ifrik’s picture

Can you please make an interdiff, so that we can see what you have changed in the last patch?

ifrik’s picture

I've removed the unnecessary "internal" but kept the "add" because the module adds and not changes link.s

I ignored the two latest patches, because I'm pretty much off-grid and didn't have time to dig into what was done there.

snehi’s picture

Status: Needs review » Reviewed & tested by the community

Patch looks good to me and we should close it.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

URL aliases description looks both accurate and simplified enough to me now, thanks.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 5c2bf5d on 8.0.x
    Issue #2578989 by ifrik, alvar0hurtad0, jhodgdon, Bojhan, snehi, mairi,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.