In #2543340: Convert BlockViewBuilder to use #lazy_builder (but don't yet let context-aware blocks be placeholdered) an empty file was committed by accident: core/lib/Drupal/Core/Cache/Context/OriginalRequestCacheContext.php.

We should remove this file since it interferes with automatic coding standards checking.

CommentFileSizeAuthor
#5 2575419-5.patch893 bytespfrenssen
#2 2575419-2.patch197 bytespfrenssen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen as a volunteer commented
Status: Active » Needs review
FileSize
2575419-2.patch197 bytes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Component: block.module » cache system
Status: Needs review » Reviewed & tested by the community
Issue tags: +Trivial patch of the month, +DrupalCon Barcelona 2015
Related issues: +#2543340: Convert BlockViewBuilder to use #lazy_builder (but don't yet let context-aware blocks be placeholdered)

Keeping at "normal" because We should remove this file since it interferes with automatic coding standards checking..

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work

Need to fix phpcs.xml now

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen as a volunteer commented
Status: Needs work » Needs review
FileSize
2575419-5.patch893 bytes

Indeed :)

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Oh, wow, I had no idea!

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen as a volunteer commented

@WimLeers It's brand new, it was only committed after this issue was first RTBC'd, in #2573377: Add our own phpcs.xml file ;)

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer commented

Aha! Thanks for clarifying :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2575419-5.patch, failed testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer commented
Status: Needs work » Reviewed & tested by the community

Random fail in \Drupal\node\Tests\Migrate\d6\MigrateViewModesTest.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed a4bf860 and pushed to 8.0.x. Thanks!

  • alexpott committed a4bf860 on 8.0.x 
    Issue #2575419 by pfrenssen: Remove empty file...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.