Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
After installing Drupal 8 (beta-15) and choosing to automatically install it in another language (Swedish), the message "One translation string was skipped because of disallowed or malformed HTML. See the log for details." is presented to the user.
According to the "User Interface Translation" the message should have a link to the log, but the translated message doesn't print the link.
| Comment | File | Size | Author |
|---|---|---|---|
| #44 | interdiff-40-44.txt | 708 bytes | jungle |
| #44 | 2567671-44.patch | 2.08 KB | jungle |
| |||
| #40 | interdiff_39_40.txt | 590 bytes | Aadhar_Gupta |
| #40 | 2567671-40.patch | 2.57 KB | Aadhar_Gupta |
| |||
| #39 | 2567671-39.patch | 2.08 KB | karishmaamin |
Comments
Comment #2
AdamEvertsson CreditAttribution: AdamEvertsson as a volunteer commentedApparently this was reported in 2013 and the issue #2062103: Skipped translation import shows dblog link message that is not yet available in installer was closed in January 2015.
I experienced the problem in Drupal 8-beta 15 on my MacBook Pro, using MAMP to host the site. PHP 5.5.10.
(Sorry for posting a duplicate, I did search for an issue of the problem I experienced, only to find it after I posted this issue.)
Comment #3
unstatu CreditAttribution: unstatu commentednachosalvador and I are working on it in the DrupalConEur mentored sprint.
Comment #4
unstatu CreditAttribution: unstatu commentedWe were able to reproduce the bug. The steps to do it are the following:
Comment #5
unstatu CreditAttribution: unstatu commentedThe problem was that during the installation the logs are not available yet and there wasn't any specific message to show during the installation.
So, the solution that we took is to show an specific message when installing.
Comment #6
unstatu CreditAttribution: unstatu commentedComment #7
nachosalvador CreditAttribution: nachosalvador commentedI did pair programming with unstatu in DrupalCon 2015 Barcelona to create the #5 patch
Comment #9
marysalento CreditAttribution: marysalento as a volunteer and commentedThe path work for me, but the path is not working in the test. We need defined the constant MAINTENANCE_MODE in the test
Comment #10
marysalento CreditAttribution: marysalento as a volunteer and commented@elchiconube and I defined the constant MAINTENANCE_MODE in two files (core/modules/locale/src/Tests/LocaleImportFunctionalTest.php and core/modules/locale/src/Tests/LocaleUpdateTest.php) because it's necesary to pass the test.
I added also the patch of @unstatu and @nachosalvador
Comment #11
marysalento CreditAttribution: marysalento as a volunteer and commentedComment #14
nachosalvador CreditAttribution: nachosalvador as a volunteer commentedFixed MAINTENANCE_MODE definition
Comment #16
unstatu CreditAttribution: unstatu commentedThe tests were failing because the constant MAINTENANCE_MODE were not defined.
So, finally we have used drupal_installation_attempted() to check if Drupal is being installed.
Comment #17
nachosalvador CreditAttribution: nachosalvador as a volunteer commentedWorks fine and the tests passed.
Comment #21
unstatu CreditAttribution: unstatu commentedChanged to 8.0.x-dev because the problem still there.
Comment #23
Sutharsan CreditAttribution: Sutharsan as a volunteer commentedThanks for the patch, well done and a deserved green test result after 1+ day work. I checked the patch and confirm that the original translated string is not changed. Only new strings added.
Back to 'needs work' to add a test. Added the tag 'Needs tests' too.
Comment #36
larowlanAdding some tags
Removing needs tests because I don't think we need them here, testing will be arduous
Comment #37
karishmaamin CreditAttribution: karishmaamin at Specbee commentedRe-rolled patch against 9.5.x. Please review
Comment #38
needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #39
karishmaamin CreditAttribution: karishmaamin at Specbee commentedSorry, there was Custom command failure #37. Here is the patch fixing that
Comment #40
Aadhar_Gupta CreditAttribution: Aadhar_Gupta at OpenSense Labs for DrupalFit commentedAdding Reroll for Drupal 10
Comment #41
Aadhar_Gupta CreditAttribution: Aadhar_Gupta at OpenSense Labs for DrupalFit commentedI applied the #39 patch on my local and it got applied but somehow I missed that part and applied php-cs and php-cbf there was a minor change so I created an interdiff and uploaded the patch so this patch can be considered as improved code quality.
Comment #42
Ranjit1032002I had Reviewed the patch and it's working as expected mentioned in comment #40
Comment #43
larowlanThis change is out of scope
Comment #44
jungleAddressing #43. RTBC, unless the CI rejects. The current dev branch is 10.1.x
Comment #45
larowlanCan we trace down when the URL param was removed? The original issue summary says there was originally a link but it wasn't in the string.
i.e. I think the original issue has been resolved and I'm not sure we're gaining much with the current patch.
It looks to me like the original issue was fixed in #2062103: Skipped translation import shows dblog link message that is not yet available in installer - so either we need an issue summary update with the new intent or we can close this as duplicate.
Please advise.