Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up from #2451411-102: Add libraries-override to themes' *.info.yml, @Cottser said:
After manual testing, some thoughts:
- Should the "entire library override" option check to make sure the replacement library exists (or is false)? Otherwise it fails silently from what I can tell.
- Should we check to make sure that the library being specified on the left hand side exists? Otherwise a typo will fail silently.
- Should we check to make sure an individual asset on the left side exists?
Maybe these should all fail silently so we don't have people creating dependencies on things they are wanting to remove/override but I accidentally ran into the second case while testing by typo'ing. Seems like we'd want to make sure the library exists at minimum.
Assertions are best for this. This issue is about using assertions.
Comments
Comment #2
almaudoh CreditAttribution: almaudoh commentedComment #9
John Cook CreditAttribution: John Cook at Creode commentedMoving to theme system component.
As #2451411: Add libraries-override to themes' *.info.yml has been committed, I'm changing to active status.