A follow up to #2501711-28: Remove or document SafeMarkup::set in template_preprocess_ckeditor_settings_toolbar

CommentFileSizeAuthor
#5 comment_on_or_replace-2548723-5.patch891 byteschrisfromredfin
#2 2548723-2.patch996 bytesWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer and at Acquia commented
Status: Active » Needs review
FileSize
2548723-2.patch996 bytes
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
CreditAttribution: chrisfromredfin at Redfin Solutions, LLC commented

This is exactly why. It might be clearer to mention something like "CKEditor needs these class names to be exactly what it expects in its library, and cleanCssIdentifier does not make it match." But that could be a bikeshed. Just offering my $0.02 to keep pushing forward.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer and at Acquia commented

@cwells If you find that clearer, that works for me. Please update the patch? :)

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
CreditAttribution: chrisfromredfin at Redfin Solutions, LLC commented
FileSize
comment_on_or_replace-2548723-5.patch891 bytes

Here's my version!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Documentation

Thanks! :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 42a5ff9 and pushed to 8.0.x. Thanks!

  • alexpott committed 42a5ff9 on 8.0.x 
    Issue #2548723 by Wim Leers, cwells: Comment on or replace class name...

Status: Fixed » Needs work

The last submitted patch, 5: comment_on_or_replace-2548723-5.patch, failed testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.