Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2542124: Drupal\views\Tests\Handler\FieldFieldTest fails on Postgres
Drupal test run
---------------
Tests to be run:
- Drupal\node\Tests\Views\RevisionRelationshipsTest
Test run started:
Wednesday, July 29, 2015 - 15:21
Test summary
------------
Drupal\node\Tests\Views\RevisionRelationshipsTest 2 passes 1 fails
Comment | File | Size | Author |
---|---|---|---|
#3 | 2542128.3.patch | 850 bytes | alexpott |
#3 | 1-3-interdiff.txt | 700 bytes | alexpott |
#1 | 2542128.1.patch | 858 bytes | alexpott |
Comments
Comment #1
alexpottSort missing :)
Comment #2
bzrudi71 CreditAttribution: bzrudi71 commentedTestet locally and tests pass now. Thanks @alex for the quick fix!
Comment #3
alexpottSlight c&p fail :(
Comment #4
catchSince this adds a sort, I took a look at the indexes on node_field_revision:
Looks like it would be useful to add an index on nid, vid in case a real life view was set up like this. I'll open a follow-up.
Went to commit the patch, but it doesn't apply?
Comment #5
catchFollow-up created: #2546702: Review entity sql storage indexes.
Comment #6
alexpottPatch in #3 applies fine for me.
Comment #9
catchNot sure why I couldn't get this apply before, but now can.
Committed/pushed to 8.0.x, thanks!