Can't add multiple content types to shortcuts

This issue is introduced in #2478151: Shortcuts to pages generated by views are not recognized as added to the shortcutset and are being added multiple times. After reverting that commit the issue got fixed.

Looks like the issue in the last issue was that it was using the full parameters instead of the raw parameters.

As the patch removed the check for the full parameters it was only checking on route name. The route name for all content types is node.add they they are seen as the same page.

This patch should fix this issue and still work for admin/people.

@lahoosascoots nice fix. Can we add quick tests for the issue described in IS? You can look at test added in #2478151: Shortcuts to pages generated by views are not recognized as added to the shortcutset and are being added multiple times for reference.

With tests. Test only patch should fail.

(Oops, put wrong comment #)

Guess my test patches wern't good.

And fixing my indentation issue.

Will fix anything that pops up tomorrow.

+++ b/core/modules/shortcut/src/Tests/ShortcutLinksTest.php
@@ -153,6 +153,16 @@ public function testShortcutQuickLink() {
+    //Test two pages which use the same route name but different route parameters
...
+    //Assure that Article does not have its shortcut indicated as set

Needs a space after // and first line is more then 80 chars. Please see https://www.drupal.org/node/1354#inline for reference.

Comments fixed.

oops sorry for the inconvenience..
Manually tested patch in #17 and it seems to solve the issue and it doesn't seems to generate problems with pages generated by views.
Patch looks good, just a nitpick

+++ b/core/modules/shortcut/src/Tests/ShortcutLinksTest.php
@@ -153,6 +153,16 @@ public function testShortcutQuickLink() {
+    // Test two pages which use same route name but different route parameters
...
+    // Add Shortcut for Basic Page
...
+    // Assure that Article does not have its shortcut indicated as set

Comments need a trailing period

How DARE you make me do 4 more seconds of work!? =P

Should be the final patch.

Looks good to me

+++ b/core/modules/shortcut/src/Tests/ShortcutLinksTest.php
@@ -153,6 +153,16 @@ public function testShortcutQuickLink() {
+    $link = $this->xpath('//a[normalize-space()=:label]', array(':label' => 'Remove from Default shortcuts'));
+    $this->assertTrue(empty($link), 'Link Remove to Default shortcuts not found for Create Article page.');

This is a negative assertion - can we also click the link to add the shortcut for the article page and ensure it gets added.

Great idea. Here we go. Setting it back to RTBC because I just added two asserts.

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 84713a3 and pushed to 8.0.x. Thanks!