Problem/Motivation

  1. It is extremely brittle to fire a hook while rebuilding module data. If you remove a module implementing hook_system_info_alter I think you'll find yourself in quite a pickle for example.
  2. All the work _system_rebuild_module_data does can be cached across tests (for any given test run) per profile if the hook is gone.
  3. It had two purposes: module uninstall removed by #2392293: Refactor hook_system_info_alter implementations to use ModuleUninstallValidatorInterface and module provided themes for testing which are either removed or removable since #1292284: Require 'type' key in .info.yml files

Proposed resolution

Kill the hook.

Remaining tasks

User interface changes

API changes

Comments

Fabianx’s picture

larowlan’s picture

fwiw I've used this for other reasons too, e.g. to diddle with dependencies or load a newer version of a module from profiles (instead of sites all).

moshe weitzman’s picture

This is the child of a Performance issue - #2470679: [meta] Identify necessary performance optimizations for common profiling scenarios. Is this truly a performance issue?

chx’s picture

For test runs persisting this data across tests can be a speedup. It's more of a bug really to fire a hook during hook data rebuild ...

chx’s picture

Status: Active » Closed (won't fix)

based on #2 this is needed.