Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
- It is extremely brittle to fire a hook while rebuilding module data. If you remove a module implementing hook_system_info_alter I think you'll find yourself in quite a pickle for example.
- All the work _system_rebuild_module_data does can be cached across tests (for any given test run) per profile if the hook is gone.
- It had two purposes: module uninstall removed by #2392293: Refactor hook_system_info_alter implementations to use ModuleUninstallValidatorInterface and module provided themes for testing which are either removed or removable since #1292284: Require 'type' key in .info.yml files
Proposed resolution
Kill the hook.
Comments
Comment #1
Fabianx CreditAttribution: Fabianx for Acquia commentedComment #2
larowlanfwiw I've used this for other reasons too, e.g. to diddle with dependencies or load a newer version of a module from profiles (instead of sites all).
Comment #3
moshe weitzman CreditAttribution: moshe weitzman at Acquia commentedThis is the child of a Performance issue - #2470679: [meta] Identify necessary performance optimizations for common profiling scenarios. Is this truly a performance issue?
Comment #4
chx CreditAttribution: chx commentedFor test runs persisting this data across tests can be a speedup. It's more of a bug really to fire a hook during hook data rebuild ...
Comment #5
chx CreditAttribution: chx commentedbased on #2 this is needed.