Problem/Motivation

At the moment theme registry cache built has been limited for GET requests only because for some reason we don't allow setting theme registry persistable on POST requests.

Proposed resolution

Make theme registry persistable on POST request.

Remaining tasks

-Write tests
-Write patch fixing the problem

User interface changes

-

API changes

-

Comments

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Category: Task » Bug report

This seems more like a bug to me.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Druid commented
Status: Active » Postponed

Postponing till #2472285: Make theme registry cache collector lazyload gets in

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

Kind of sounds like a feature request... @lauriii could you flush out the issue summary a bit further to explain why you need this? Also if it's a feature request bump it to 8.1.x or 9.x please

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

@lauriii do you mean "between POST requests" instead of "on POST request"? I'm not following where it's persistable, where is this in the code?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Version: 8.1.x-dev » 8.2.x-dev

Adding this functionality would definitely be a minor version target, so moving to 8.2.x.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Druid commented
Status: Postponed » Closed (duplicate)

The core committers (@xjm, @alexpott, @catch, @effulgentsia, @Cottser) and theme maintainers (@lauriii, @joelpittet) discussed this issue today and agreed that this issue should be marked as a duplicate for #2472285: Make theme registry cache collector lazyload.

This was originally created because it might make sense to change this assumption in some use cases where there is a lot of rendering is done on the POST requests. That is not possible because of #2472285: Make theme registry cache collector lazyload unless one overrides the __construct method to change it's behavior.

We agreed that we don't have to change this assumption by default, but we should instead fix the duplicated issue to allow module developers easily change the behavior.